Skip to content

feat(build.sbt): removing scala 2.11 and upgrading cats and cats effe…#320

Merged
felixbr merged 1 commit intotypelevel:masterfrom
brbrown25:ISSUE-213
May 11, 2021
Merged

feat(build.sbt): removing scala 2.11 and upgrading cats and cats effe…#320
felixbr merged 1 commit intotypelevel:masterfrom
brbrown25:ISSUE-213

Conversation

@brbrown25
Copy link
Copy Markdown
Contributor

@brbrown25 brbrown25 commented May 10, 2021

…ct versions. #213.

@brbrown25 brbrown25 mentioned this pull request May 10, 2021
Merged
@felixbr felixbr mentioned this pull request May 11, 2021
Closed
@brbrown25
Copy link
Copy Markdown
Contributor Author

brbrown25 commented May 11, 2021

I'll fix failing test shortly!

@brbrown25
Copy link
Copy Markdown
Contributor Author

brbrown25 commented May 11, 2021

@felixbr The broken compile should be fixed now.

@felixbr
Copy link
Copy Markdown
Contributor

felixbr commented May 11, 2021 •
edited
Loading

Since you upgraded Scala 2.12 and 2.13 as well (specifically 2.12.13), we're now in a bit of a catch-22. Either you don't upgrade those versions or you also upgrade sbt-scoverage to 1.8.0 and see if that fixes the issue (see here: #321)

@brbrown25
Copy link
Copy Markdown
Contributor Author

brbrown25 commented May 11, 2021

oh I think I remember this one, you can't run coverage under 2.12.13, pushing an update for that now

@brbrown25
Copy link
Copy Markdown
Contributor Author

brbrown25 commented May 11, 2021

Since you upgraded Scala 2.12 and 2.13 as well (specifically 2.12.13), we're now in a bit of a catch-22. Either you don't upgrade those versions or you also upgrade sbt-scoverage to 1.8.0 and see if that fixes the issue (see here: #321)

I'll roll back 2.13 as well so that it doesn't conflict with the other pr

@brbrown25 brbrown25 force-pushed the ISSUE-213 branch 2 times, most recently from 84b4efb to 62e3d12 Compare May 11, 2021 13:18
@brbrown25
Copy link
Copy Markdown
Contributor Author

brbrown25 commented May 11, 2021

it looks like I need to upgrade everything to make everything pass, since the cats libs are compiled with higher scala versions

@felixbr felixbr merged commit a64efc1 into typelevel:master May 11, 2021
@felixbr
Copy link
Copy Markdown
Contributor

felixbr commented May 11, 2021

Thanks 🙂

@felixbr felixbr mentioned this pull request May 11, 2021
Closed
@brbrown25 brbrown25 deleted the ISSUE-213 branch May 11, 2021 13:41
@felixbr felixbr mentioned this pull request May 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@brbrown25 @felixbr