Skip to content

docker: refresh the node:22-bookworm-slim digest; record the deferred Node 24 and frontend-tooling work - #107

Merged
tyler-rich merged 1 commit into
devfrom
claude/node-22-digest-roadmap-7y3yfv
Jul 26, 2026
Merged

docker: refresh the node:22-bookworm-slim digest; record the deferred Node 24 and frontend-tooling work#107
tyler-rich merged 1 commit into
devfrom
claude/node-22-digest-roadmap-7y3yfv

Conversation

@tyler-rich

@tyler-rich tyler-rich commented Jul 26, 2026

Copy link
Copy Markdown
Owner

Two small items: one stale digest pin, and three decisions that existed nowhere a reader would find them.

1. node:22-bookworm-slim digest refreshed

docker/Dockerfile's frontend-builder base was pinned at sha256:53ada149…; the tag now resolves to sha256:6c74791e…Node 22.23.1 (jod), pushed 2026-07-14.

Verified against the registry rather than taken from bump metadata:

  • registry-1.docker.io's manifest endpoint returns 6c74791e… for the 22-bookworm-slim tag.
  • That index is an OCI image index carrying both linux/amd64 and linux/arm64 — both legs of the multi-arch build.
  • Docker Hub's tag listing shows the same digest shared by 22.23.1-bookworm-slim, 22.23-bookworm-slim, and jod-bookworm-slim, which is what actually establishes the version behind the moving tag.

Nothing structural changed. No stage boundary, no layer ordering, no cache scope — only the digest, plus a comment on the FROM line recording why it stays on 22 and where the 24 move is tracked.

Why it was stale

Same case as the debian:bookworm-slim refresh in #104, with the same cause. Dependabot's docker-images group doesn't offer digest refreshes within a major line — it offered node 22 → 26, a major on a line that is not LTS. Declining that major is correct, but declining it was all that happened, so the 22 pin sat where it was.

Why 22, and why 24 is the eventual answer

From nodejs/Release's schedule.json:

Line Status Supported through
22 (jod) maintenance since 2025-10-21 2027-04-30
24 (krypton) Active LTS since 2025-10-28 2028-04-30
26 not LTS until 2026-10-28 2029-04-30

Staying on 22 is a hold, not a decision to stay: the 24 move also touches .github/workflows/ci.yml's node-version: "22" and CONTRIBUTING.md's Node floor, and has to land as one change across all three.

2. Three deferred items written into docs/ROADMAP.md § Near-term

All three were already decided; none was recorded anywhere findable — the same failure mode as the governance-checklist items that sat invisible in §14 prose for weeks.

  • Node 22 → 24, with the three-file scope above and the note that Dependabot will keep offering 26 instead of the refresh.
  • Frontend tooling majors left over from Dependabot frontend: bump the frontend-dependencies group across 1 directory with 25 updates #86 after the Mantine/React ignores landed: TypeScript 5.7 → 7.0, ESLint 9 → 10, typescript-eslint 8.19 → 8.65, Vite 6 → 8, Vitest 3 → 4, jsdom 26 → 29, and the smaller bumps beside them. Previously recorded only as an aside inside an entry about ignoring Mantine and React. They share one risk: all of them land on the type-aware ESLint gate turned on 2026-07-24, so the work is the lint-config churn.
  • Deprecated Starlette status-code constants. Noted as "pre-existing" in the validation paragraph of both interpreter-bump entries and cleared by neither.

A count correction on that last item

It was scoped at 44 call sites. From the tree it is 22scans.py ×10, scan_schedules.py ×4, registries.py ×3, notifications.py ×2, one each in trivy_policy.py, git_credentials.py, backups.py — plus 2 more for the sibling HTTP_413_REQUEST_ENTITY_TOO_LARGE rename in uploads.py, which the same archive note pairs with it. Verified against the pinned starlette 1.3.1, not assumed from the warning text: both old names resolve and warn, the replacements HTTP_422_UNPROCESSABLE_CONTENT / HTTP_413_CONTENT_TOO_LARGE exist, and each pair is the same integer — so the cleanup cannot move a status code.

Validation

The local container has no Python 3.14, so the backend suite was not run here and is not claimed to have been — CI is the gate, and backend code is untouched by this PR. What was checked directly: the digest against registry-1.docker.io and the Docker Hub tag API, the Node dates against nodejs/Release, the Starlette constants against an install of the exact pinned version. The image build + dogfood self-scan in CI is the meaningful check on the digest change.

See docs/ARCHIVE.md § 14 for the dated entry.

… Node 24 and frontend-tooling work

Rolls the frontend-builder base digest forward to the current
node:22-bookworm-slim. Verified against the registry rather than taken from
bump metadata: registry-1.docker.io resolves the 22-bookworm-slim tag to
6c74791e..., that index carries both linux/amd64 and linux/arm64, and Docker
Hub's tag listing shows the same digest on 22.23.1-bookworm-slim and
jod-bookworm-slim, which is what establishes the version behind the moving
tag. No stage boundary, layer ordering, or cache scope changed.

Same case as the debian refresh in #104: Dependabot's docker-images group
offers node 22 -> 26, a major on a line that is not LTS, not a digest refresh
within 22, so declining the major left the pin stale. Node 22 is supported
through 2027-04-30; 24 (Active LTS, through 2028-04-30) is the target and 26
is not LTS until 2026-10-28.

Also records three items that had been decided but written down nowhere a
reader would find them, in docs/ROADMAP.md near-term: the Node 22 -> 24 move
(Dockerfile + ci.yml + CONTRIBUTING together), the frontend tooling majors
left over from Dependabot #86 after the Mantine/React ignores (TypeScript
5.7 -> 7.0, ESLint 9 -> 10, typescript-eslint 8.65, Vite 6 -> 8, Vitest
3 -> 4, jsdom 26 -> 29, all landing on the type-aware ESLint gate), and the
deprecated Starlette HTTP_422_UNPROCESSABLE_ENTITY / HTTP_413_REQUEST_ENTITY_
TOO_LARGE constants at 22 and 2 call sites.

See docs/ARCHIVE.md section 14 for the dated entry.
@tyler-rich
tyler-rich merged commit 7034d98 into dev Jul 26, 2026
4 checks passed
@tyler-rich
tyler-rich deleted the claude/node-22-digest-roadmap-7y3yfv branch July 31, 2026 04:59
tyler-rich added a commit that referenced this pull request Aug 2, 2026
The ignore is scoped to version-update:semver-major so digest refreshes
of the pinned 22 tag keep arriving, but that rests on documented
update-types semantics plus reported updater behaviour - not on an
observed run in this repository. Says so, names the first scheduled
docker run as the test, and records the fallback if it is wrong (refresh
the digest by hand, as #107 did).
tyler-rich added a commit that referenced this pull request Aug 2, 2026
* backend: bump fastapi 0.140.0 -> 0.140.13 and regenerate requirements.lock

Reapplies the bump Dependabot proposed in #127, which could not merge as
opened: Dependabot edits pyproject.toml without touching
backend/requirements.lock, so CI's drift gate rejects it. The lock is
regenerated with the pinned command from CONTRIBUTING.md § Backend
dependency lock (uv 0.8.17, --group build --generate-hashes
--python-version 3.14) and moves three lines: fastapi's version and its
two wheel hashes. starlette stays at the explicitly-pinned 1.3.1.

All thirteen patch releases are internal dependency-tree/OpenAPI
refactors (0.140.1-0.140.7) or fixes to paths this backend does not use
- SSE/JSONL streaming, response_model_* on Iterable returns,
jsonable_encoder's exclude_defaults, and nested-Annotated sequence
params. Verified by grep: no jsonable_encoder, no StreamingResponse, no
SSE helper, no response_model_* anywhere in backend/app.

Confirmed against the regenerated lock rather than the version pin: a
venv on CPython 3.14.6 built the way the image builds (pip install
--require-hashes -r requirements.lock, then pip install --no-deps
--no-build-isolation .) runs the full suite green - 666 passed, 5
skipped, identical to the pre-bump baseline.

* ci: bump docker/login-action 4.5.1 -> 4.5.2

Reapplies what Dependabot proposed in #128, SHA-pinned per the repo's
Actions convention with the tag as a trailing comment.

The commit SHA was resolved from upstream with git ls-remote --tags
against docker/login-action rather than read off the bump description -
refs/tags/v4.5.2 maps to 371161bbe7024a29a25c5e19bfcbc0804fe9ad2c.
Trusting a rendered SHA is the substitution a SHA pin exists to prevent.

v4.5.2 contains one substantive commit, "surface Docker Hub OIDC error
responses" (docker/login-action#1058): it improves the error text when a
Docker Hub OIDC login fails. All three call sites here log in to ghcr.io
with the built-in GITHUB_TOKEN as username/password - not Docker Hub,
not OIDC - so the changed path is never entered. No input, output, or
breaking changes. This matters because these workflows run only on the
tag-gated publish path and the nightly, which CI cannot exercise.

* ci(dependabot): ignore node majors and the local scrye build tag

Two ignore entries, both closing a recurring failure.

node majors, on the docker entry. #126 proposed node
22-bookworm-slim -> 25-bookworm-slim. Node's odd-numbered lines never
become LTS: v25 reached end-of-life on 2026-06-01, before that PR was
opened and years before the 22 line's 2027-04-30, so it would have moved
the frontend builder onto an unsupported runtime. The wanted move is
22 -> 24 (Active LTS, 2028-04-30) and is tracked in docs/ROADMAP.md
because it spans the Dockerfile, ci.yml and CONTRIBUTING.md together.

The ignore is scoped to version-update:semver-major so digest refreshes
of the pinned 22 tag still come through - declining a major previously
left Dependabot offering nothing for this image and the digest went
stale until #107 refreshed it by hand.

dependency-name: scrye, on both docker entries. docker/docker-compose.yml
pins image: scrye:0.2.0, Scrye's own locally-built tag; Dependabot
resolves the unqualified name as Docker Hub's library/scrye, gets a 401,
and fails the run with private_source_authentication_failure. Reading the
files confirms the compose file carries the only such reference and
docker/Dockerfile carries none, so the substantive entry is on the
docker-compose ecosystem; it is repeated on the docker entry because the
failing run's ecosystem is visible only in the Dependabot UI, and
suppressing a name the Dockerfile never mentions costs nothing.

The image tag itself is unchanged: qualifying it as
ghcr.io/tyler-rich/scrye:0.2.0 would make the compose file pull a
published image instead of building locally, changing what the
documented quick start does.

* docs: record the post-v0.2.0 dependency cleanup and the base-branch diagnosis

A version update sitting on main is not the documented security-update
case. #126, #127 and #128 were all opened against dev correctly - their
head branches carry the /dev/ target-branch segment - and each records an
automatic_base_change_succeeded event 2-3 seconds after the v0.2.0
promotion (#122) merged. GitHub retargets open PRs whose base branch is
deleted to the merged PR's base, and auto-delete-on-merge deleted dev as
the promotion's head branch. dependabot.yml was not involved, and neither
was grouped security updates: all three are version updates across three
different ecosystems. The remedy is already in place (auto-delete
disabled on 2026-08-02); target-branch and the grouping setting stay as
they are.

CLAUDE.md § Dependency hygiene and a new CONTRIBUTING.md subsection carry
the rule and a two-signal table for telling the two causes apart.

docs/ROADMAP.md: the Node 22 -> 24 item rewritten to state that it must
be its own PR with a registry-verified digest pin, and to name the three
files that have to move together - bumping the Dockerfile alone would
leave CI on 22 while the image builds on 24. New item for enabling
GitHub code scanning (CodeQL) on Python and TypeScript: free for public
repos, default setup adds a workflow running on every push and PR, and
the first run surfaces a triage backlog, so it wants its own session.

docs/ARCHIVE.md gains the dated §14 entry covering all of it, including
the correction to #125: GHSA-mh99-v99m-4gvg was re-scoped per major on
2026-07-31 and 1.1.18 / 2.1.4 are both above their line's first patched
version, so the #121 bump did clear it. Verified at the source - 1.1.17
and 2.1.3 introduce EXPANSION_MAX_LENGTH and name CVE-2026-14257 in
their comments - not from the advisory metadata that produced the wrong
claim in the first place. #125 closed on its own stated criterion; #123
and #124 re-verified and still accurate.

* docs: distinguish base_ref_changed from automatic_base_change_succeeded

The retarget diagnosis said #110 and #120 have "no such event", which is
true of automatic_base_change_succeeded but reads as though their
timelines are bare. #120 carries two ordinary base_ref_changed events -
the manual retarget-to-dev-and-back already documented on 2026-07-31 -
so a reader checking a timeline needs the event types told apart, not
just the presence of a base change.

* docs: state the evidence for the node digest-refresh assumption

The ignore is scoped to version-update:semver-major so digest refreshes
of the pinned 22 tag keep arriving, but that rests on documented
update-types semantics plus reported updater behaviour - not on an
observed run in this repository. Says so, names the first scheduled
docker run as the test, and records the fallback if it is wrong (refresh
the digest by hand, as #107 did).

* ci: pin docker/login-action to v4.6.0 rather than v4.5.2

Supersedes the 4.5.2 applied earlier in this branch. 4.5.2's only
substantive commit improves Docker Hub OIDC error text, a path none of
the three call sites can reach - all three log in to ghcr.io with the
built-in GITHUB_TOKEN as username/password. 4.6.0 lands a day later and
its change is at least adjacent to what this repo does: it hardens the
buildx-scoped config path used by the login -> buildx -> push chain, and
carries the action's own bundled dependency bumps.

SHA resolved from upstream with git ls-remote --tags, not from a
changelog: refs/tags/v4.6.0 -> dbcb813823bdd20940b903addbd779551569679f.
The moving v4 tag currently points at the same commit; the pin is the
immutable v4.6.0 commit, not the alias.

Read at the source by diffing v4.5.2...v4.6.0 rather than from the
release notes, because these workflows run only on the tag-gated publish
path and the nightly, which CI cannot exercise. action.yml is
byte-identical, src/main.ts and src/docker.ts are unchanged, and the
whole change is in src/context.ts's buildx scoped-config-dir helper -
path.resolve containment on the registry and scope inputs behind a new
isChildPath() helper.

Behaviourally a no-op here: that helper returns early on
'if (scopeDisabled() || !scope || scope === "")', and no call site
passes a scope input. Currency plus defence-in-depth, not a fix for
anything reachable.

* frontend: bump postcss 8.5.16 -> 8.5.25 (GHSA-r28c-9q8g-f849)

Applied by hand rather than waiting for Dependabot: it has not proposed
this, and after closing #126/#127/#128 there are no open Dependabot PRs
at all, so a HIGH advisory was waiting on a bot that was not going to
act.

Which version actually clears it was verified in the published source,
not taken from the advisory range - GHSA-mh99-v99m-4gvg was re-scoped
mid-flight and #125 was wrong because of it. postcss 8.5.18's
lib/previous-map.js loadFile() gains the containment check the advisory
describes (relative(dirname(cssFile), path) rejected when it is '..',
starts with '../', or is absolute); 8.5.17 has none of it. So 8.5.18 is
the real floor. The same check is still present in 8.5.25, which is what
is pinned - current release on the pinned 8.5 line, per CLAUDE.md
§ Dependency hygiene.

No overrides entry needed and no parent bumped: postcss is a direct
devDependency here, and every package that also reaches it declares a
peer/caret range 8.5.25 satisfies (vite's ^8.5.3 included), so raising
the single pin lifts the tree and npm ls shows one deduped copy.

Regenerated with npm pkg set + npm install --package-lock-only, not by
editing version strings, so resolved URLs and integrity hashes moved
with the version. Diff is postcss 8.5.16 -> 8.5.25, its nanoid floor
^3.3.12 -> ^3.3.16, and nanoid 3.3.15 -> 3.3.16 - all dev-only, no new
packages.

npm ci installs 8.5.25 with the containment check present; ESLint,
Prettier, the 20-file/69-test Vitest suite and npm run build all pass;
npm audit no longer reports postcss. Nothing ships either way - postcss
runs during vite build and the image copies only dist/.

* docs: record the 4.6.0 pin and the postcss bump in the dated entry

The §14 entry's login-action item now covers 4.6.0 and why it was taken
over the 4.5.2 that #128 proposed, including the source-level diff and
the honest note that the hardened path is gated on a scope input this
repo never passes.

The advisory-issues item gains the full postcss treatment: why it was
applied by hand, the 8.5.18 fix floor verified in the published source
rather than read off the advisory range, why no overrides entry or
parent bump was needed, and the post-bump verification. #124 closed on
its own stated criterion, the same standard applied to #125.

CHANGELOG [Unreleased] gains a Security entry for the postcss advisory -
and says explicitly that unlike the brace-expansion bump in 0.2.0, this
one does clear its advisory - plus Changed entries for the login-action
and fastapi pins.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant