Merge pull request mui#1610 from garth/fix-select-field-onchange

shaurya947 · shaurya947 · commit db23297f7151 · 2015-11-10T13:53:14.000-06:00
SelectField now triggers on change consistently when using props.value
diff --git a/src/drop-down-menu.jsx b/src/drop-down-menu.jsx
@@ -316,12 +316,12 @@ const DropDownMenu = React.createClass({
   },
 
   _onMenuItemClick(e, key, payload) {
-    if (this.props.onChange && this.state.selectedIndex !== key) {
-      let selectedItem = this.props.menuItems[key];
-      if (selectedItem) {
-        e.target.value = selectedItem[this.props.valueMember];
-      }
+    let selectedItem = this.props.menuItems[key];
+    if (selectedItem) {
+      e.target.value = selectedItem[this.props.valueMember];
+    }
 
+    if (this.props.onChange && (this.state.selectedIndex !== key || e.target.value !== this.props.value)) {
       if (this.props.valueLink) {
         this.props.valueLink.requestChange(e.target.value);
       }
