Merged
Conversation
Refactor copyToClipboard to use a table-driven candidate list with environment-aware ordering. When WAYLAND_DISPLAY is set, wl-copy is preferred over X11 tools; otherwise X11 tools are tried first. Closes #445
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #446 +/- ##
==========================================
- Coverage 81.15% 81.13% -0.03%
==========================================
Files 71 71
Lines 12765 12779 +14
==========================================
+ Hits 10360 10368 +8
- Misses 2001 2006 +5
- Partials 404 405 +1
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
wl-copy(fromwl-clipboard) as a supported clipboard provider in the TUI detail view, enabling copy-to-clipboard on Wayland-based Linux desktops.WAYLAND_DISPLAYenvironment variable to prefer the appropriate clipboard toolwl-copy→xclip→xsel(XWayland fallback)xclip→xsel→wl-copy(reverse fallback)pbcopy) behavior is unchangedMotivation
Linux distributions are increasingly adopting Wayland as the default display server (GNOME, KDE Plasma 6, Sway, Hyprland, etc.). The existing X11-only clipboard tools (
xclip,xsel) do not work in pure Wayland sessions, making the TUI's connection string copy feature non-functional for a growing number of users.Test plan
Closes #445