Conversation
Replace hardcoded dark-theme colors with a switchable palette via styles.SetDarkTheme(). The light palette uses darker color variants (dark gold, dark green, dark teal, black text) optimized for light terminal backgrounds. Add --theme CLI flag and KUBEFWD_THEME env var to override the default dark theme. Priority: flag > env var > default (dark). Usage: sudo -E kubefwd svc -n ns --tui --theme light KUBEFWD_THEME=light sudo -E kubefwd svc -n ns --tui
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #393 +/- ##
==========================================
+ Coverage 81.13% 81.15% +0.02%
==========================================
Files 70 71 +1
Lines 12665 12765 +100
==========================================
+ Hits 10276 10360 +84
- Misses 1985 2001 +16
Partials 404 404
🚀 New features to boost your workflow:
|
FOSSA's JS dependency scanning requires a paid account for exclusions and consistently fails on documentation build dependencies.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--themeflag (light/dark) andKUBEFWD_THEMEenv var to control TUI color schemestyles.SetDarkTheme()Closes #392
Usage
Test plan
go build ./...compiles cleanlygo test ./...all tests pass--theme lighton a light terminal: text is readable with dark/muted colors--theme dark(or no flag): original bright colors unchangedKUBEFWD_THEME=lightenv var works as override