Merged
Conversation
- Updated `.goreleaser.yml` to sign both archive and checksum artifacts using Cosign (keyless OIDC). - Added specific arguments and signature templates for artifact signing.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #359 +/- ##
=======================================
Coverage 63.91% 63.91%
=======================================
Files 70 70
Lines 12457 12461 +4
=======================================
+ Hits 7962 7965 +3
- Misses 4165 4166 +1
Partials 330 330
🚀 New features to boost your workflow:
|
- Added a `-timeout=60s` flag to fuzz tests to ensure a total timeout for each test’s setup and teardown process.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
kubefwd now automatically detects the correct hosts file path based on the operating system:
C:\Windows\System32\drivers\etc\hosts/etc/hostsPreviously, the
--hosts-pathflag defaulted to/etc/hostson all platforms, causing kubefwd to fail immediately on Windows with "Hosts path does not exist: /etc/hosts".Changes
runtimeimport to detect OS at runtimedefaultHostsPath()function that returns OS-appropriate path--hosts-pathflag to use dynamic defaultType of Change
Related Issues
Fixes Windows support for kubefwd.
Testing
go test ./...locallyTest Steps
GOOS=windows GOARCH=amd64 go build -o kubefwd.exe ./cmd/kubefwdkubefwd.exe --helpshows correct default pathkubefwd.exe svc -n <namespace>works without--hosts-pathflagChecklist
go fmt,go vet)Screenshots/Logs (if applicable)
Before (Windows):
After (Windows):