Cleanup after behavior was clarified#7
Merged
twof merged 3 commits intoQueryLevelNullabilityfrom May 10, 2021
Merged
Conversation
Owner
Author
|
@fotoetienne tagging you since this is relevant to some changes you made. |
fotoetienne
reviewed
May 8, 2021
fotoetienne
left a comment
There was a problem hiding this comment.
I had one minor comment, but looks good!
twof
pushed a commit
that referenced
this pull request
Oct 18, 2021
* Comments on the proposal Hi, thanks for this extensive and in-depth work. I will try to keep my comments concise (which might make them sound agressive, apologies if that's the case, it's definitely not the intent) This PR touches one of the most challengeable founding philosophical choices of GraphQL: having 2 different type systems for input and output. I understand that the sender -> receiver relation is an unbalanced one: the sender has obligations, the receiver has options. However: - ALL GraphQL users use programming languages (Javascript, Java, C#, Python...) which make no difference between input and output types - I actually don't know any other protocol that does that (is there one?) - having 2 different type systems for input and output solves (does it?) an implementer problem, not a user problem The lack of polymorphism on input is only a side-effect of the aformentioned original choice. In an unreal world, rather than tweak GraphQL to fix that, it would be time for GraphQL2, unifying input and output types (amongst other improvements). That's very unlikely to happen, but saying so helps forming an opinion on the various proposals: - adding yet another polymorphic construct only available on input 'smells' like increasing confusion - it would increase the gap between input and output type systems, rather than reduce it From there, I think proposal #5 @OneOf is the most useful one: - it acts as a constraint on existing type constructs rather than yet another type construct - it expresses the required behavior much better than proposal #7 * Comments on the proposal Hi, thanks for this extensive and in-depth work. I will try to keep my comments concise (which might make them sound agressive, apologies if that's the case, it's definitely not the intent) This PR touches one of the most challengeable founding philosophical choices of GraphQL: having 2 different type systems for input and output. I understand that the sender -> receiver relation is an unbalanced one: the sender has obligations, the receiver has options. However: - ALL GraphQL users use programming languages (Javascript, Java, C#, Python...) which make no difference between input and output types - I actually don't know any other protocol that does that (is there one?) - having 2 different type systems for input and output solves (does it?) an implementer problem, not a user problem The lack of polymorphism on input is only a side-effect of the aformentioned original choice. In an unreal world, rather than tweak GraphQL to fix that, it would be time for GraphQL2, unifying input and output types (amongst other improvements). That's very unlikely to happen, but saying so helps forming an opinion on the various proposals: - adding yet another polymorphic construct only available on input 'smells' like increasing confusion - it would increase the gap between input and output type systems, rather than reduce it From there, I think proposal #5 @OneOf is the most useful one: - it acts as a constraint on existing type constructs rather than yet another type construct - it expresses the required behavior much better than proposal #7 * Update InputUnion.md * clean up merge dirt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were some remnants describing how Swift force unwrapping works after Stephen clarified the behaviour to be similar to SDL non-null behaviour, so I've removed those.