Add deterministic serializer for BigDecimal #312
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Collaborator
|
Thanks for the PR! |
gdiet
added a commit
to testbench-cs-imbus/chill
that referenced
this pull request
Jun 15, 2018
PR twitter#312 registered the serializer for BigDecimal with ID 15, moving all serialization IDs from 15 on one up. This breaks compatibility for projects using chill for long term persistence - see com.twitter.chill.RegistrationIdsSpec which failed just for that reason. In this commit, the registration of BigDecimal is moved to ID 144 (the end of the list) and the RegistrationIdsSpec is updated accordingly.
johnynek
added a commit
that referenced
this pull request
Jun 15, 2018
fixed tests broken by PR #312
Collaborator
|
Hi, just checking if there's any plan to make a release? The last one was 5 months old. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scala's
BigDecimalclass has some stateful fields that result in an encoding that isn't determined by only the value. This causes problems in a framework like Apache Beam where serialized bytes are used to perform mutation checking on values (see spotify/scio#1170).This PR addresses the problem by registering a deterministic
BigDecimalSerializer, which simply encodes the underlying JavaBigDecimalinstance, which is immutable.