Skip to content

Conversation

@johnynek
Copy link
Collaborator

@johnynek johnynek commented Apr 4, 2018

cherry pick of #306

@ianoc
Copy link
Collaborator

ianoc commented Apr 4, 2018

merge when green

@codecov-io
Copy link

Codecov Report

Merging #308 into develop will increase coverage by 0.1%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           develop    #308     +/-   ##
=========================================
+ Coverage    52.59%   52.7%   +0.1%     
=========================================
  Files           42      43      +1     
  Lines         1327    1330      +3     
  Branches        38      36      -2     
=========================================
+ Hits           698     701      +3     
  Misses         629     629
Impacted Files Coverage Δ
.../com/twitter/chill/VolatileByteRefSerializer.scala 100% <100%> (ø)
...cala/com/twitter/chill/ScalaKryoInstantiator.scala 99.21% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0ea8a9...bb2664e. Read the comment docs.

@ianoc ianoc merged commit 6938e68 into develop Apr 4, 2018
@ianoc ianoc deleted the oscar/cherry_pick_volatile_byte_dev branch April 4, 2018 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants