Now that EsotericSoftware/kryo#415 was merged, I tried this again and got a little further: develop...JoshRosen:scala-2.12

It's now failing a test in the ClosureCleanerSpec:

[info] ClosureCleaner
[info] - should clean normal objects
[info] - should clean actual closures *** FAILED ***
[info]   java.lang.RuntimeException:
[info]   at com.esotericsoftware.reflectasm.shaded.org.objectweb.asm.MethodVisitor.visitParameter(Unknown Source)
[info]   at com.esotericsoftware.reflectasm.shaded.org.objectweb.asm.ClassReader.b(Unknown Source)
[info]   at com.esotericsoftware.reflectasm.shaded.org.objectweb.asm.ClassReader.accept(Unknown Source)
[info]   at com.esotericsoftware.reflectasm.shaded.org.objectweb.asm.ClassReader.accept(Unknown Source)
[info]   at com.twitter.chill.ClosureCleaner$.getInnerClassesFn(ClosureCleaner.scala:115)
[info]   at com.twitter.chill.ClosureCleaner$.com$twitter$chill$ClosureCleaner$$$anonfun$5(ClosureCleaner.scala:125)
[info]   at scala.collection.mutable.AbstractMap.getOrElseUpdate(Map.scala:80)
[info]   at com.twitter.chill.ClosureCleaner$.innerClassesOf(ClosureCleaner.scala:125)
[info]   at com.twitter.chill.ClosureCleaner$.getAccessedFields(ClosureCleaner.scala:133)
[info]   at com.twitter.chill.ClosureCleaner$.accessedFieldsOf(ClosureCleaner.scala:147)
[info]   at com.twitter.chill.ClosureCleaner$.com$twitter$chill$ClosureCleaner$$$anonfun$12(ClosureCleaner.scala:188)
[info]   at scala.collection.immutable.List.foldLeft(List.scala:84)
[info]   at com.twitter.chill.ClosureCleaner$.allocCleanedOuter(ClosureCleaner.scala:177)
[info]   at com.twitter.chill.ClosureCleaner$.apply(ClosureCleaner.scala:162)
[info]   at com.twitter.chill.ClosureCleanerSpec.com$twitter$chill$ClosureCleanerSpec$$$anonfun$4(ClosureCleanerSpec.scala:41)
[info]   at scala.runtime.java8.JFunction0$mcV$sp.apply(JFunction0$mcV$sp.java:12)
[info]   at org.scalatest.Transformer.org$scalatest$Transformer$$$anonfun$1(Transformer.scala:22)
[info]   at org.scalatest.OutcomeOf.outcomeOf(OutcomeOf.scala:85)
[info]   at org.scalatest.OutcomeOf$.outcomeOf(OutcomeOf.scala:104)
[info]   at org.scalatest.Transformer.apply(Transformer.scala:22)
[info]   at org.scalatest.Transformer.apply(Transformer.scala:20)
[info]   at org.scalatest.WordSpecLike$$anon$1.apply(WordSpecLike.scala:953)
[info]   at org.scalatest.Suite.withFixture(Suite.scala:1122)
[info]   at org.scalatest.WordSpec.withFixture(WordSpec.scala:1881)
[info]   at org.scalatest.WordSpecLike.invokeWithFixture$1(WordSpecLike.scala:951)
[info]   at org.scalatest.WordSpecLike.org$scalatest$WordSpecLike$$$anonfun$5(WordSpecLike.scala:962)
[info]   at org.scalatest.SuperEngine.runTestImpl(Engine.scala:306)
[info]   at org.scalatest.WordSpecLike.runTest(WordSpecLike.scala:962)
[info]   at org.scalatest.WordSpec.runTest(WordSpec.scala:1881)
[info]   at org.scalatest.WordSpecLike.org$scalatest$WordSpecLike$$$anonfun$6(WordSpecLike.scala:1021)
[info]   at org.scalatest.SuperEngine.org$scalatest$SuperEngine$$$anonfun$8(Engine.scala:413)
[info]   at scala.collection.immutable.List.foreach(List.scala:376)
[info]   at org.scalatest.SuperEngine.traverseSubNodes$1(Engine.scala:401)
[info]   at org.scalatest.SuperEngine.runTestsInBranch(Engine.scala:390)
[info]   at org.scalatest.SuperEngine.org$scalatest$SuperEngine$$$anonfun$8(Engine.scala:427)
[info]   at scala.collection.immutable.List.foreach(List.scala:376)
[info]   at org.scalatest.SuperEngine.traverseSubNodes$1(Engine.scala:401)
[info]   at org.scalatest.SuperEngine.runTestsInBranch(Engine.scala:396)
[info]   at org.scalatest.SuperEngine.runTestsImpl(Engine.scala:483)
[info]   at org.scalatest.WordSpecLike.runTests(WordSpecLike.scala:1021)
[info]   at org.scalatest.WordSpec.runTests(WordSpec.scala:1881)
[info]   at org.scalatest.Suite.run(Suite.scala:1424)
[info]   at org.scalatest.WordSpec.org$scalatest$WordSpecLike$$super$run(WordSpec.scala:1881)
[info]   at org.scalatest.WordSpecLike.org$scalatest$WordSpecLike$$$anonfun$7(WordSpecLike.scala:1067)
[info]   at org.scalatest.SuperEngine.runImpl(Engine.scala:545)
[info]   at org.scalatest.WordSpecLike.run(WordSpecLike.scala:1067)
[info]   at org.scalatest.WordSpec.run(WordSpec.scala:1881)
[info]   at org.scalatest.tools.Framework.org$scalatest$tools$Framework$$runSuite(Framework.scala:357)
[info]   at org.scalatest.tools.Framework$ScalaTestTask.execute(Framework.scala:529)
[info]   at sbt.TestRunner.runTest$1(TestFramework.scala:76)
[info]   at sbt.TestRunner.run(TestFramework.scala:85)
[info]   at sbt.TestFramework$$anon$2$$anonfun$$init$$1$$anonfun$apply$8.apply(TestFramework.scala:202)
[info]   at sbt.TestFramework$$anon$2$$anonfun$$init$$1$$anonfun$apply$8.apply(TestFramework.scala:202)
[info]   at sbt.TestFramework$.sbt$TestFramework$$withContextLoader(TestFramework.scala:185)
[info]   at sbt.TestFramework$$anon$2$$anonfun$$init$$1.apply(TestFramework.scala:202)
[info]   at sbt.TestFramework$$anon$2$$anonfun$$init$$1.apply(TestFramework.scala:202)
[info]   at sbt.TestFunction.apply(TestFramework.scala:207)
[info]   at sbt.Tests$$anonfun$9.apply(Tests.scala:216)
[info]   at sbt.Tests$$anonfun$9.apply(Tests.scala:216)
[info]   at sbt.std.Transform$$anon$3$$anonfun$apply$2.apply(System.scala:44)
[info]   at sbt.std.Transform$$anon$3$$anonfun$apply$2.apply(System.scala:44)
[info]   at sbt.std.Transform$$anon$4.work(System.scala:63)
[info]   at sbt.Execute$$anonfun$submit$1$$anonfun$apply$1.apply(Execute.scala:226)
[info]   at sbt.Execute$$anonfun$submit$1$$anonfun$apply$1.apply(Execute.scala:226)
[info]   at sbt.ErrorHandling$.wideConvert(ErrorHandling.scala:17)
[info]   at sbt.Execute.work(Execute.scala:235)
[info]   at sbt.Execute$$anonfun$submit$1.apply(Execute.scala:226)
[info]   at sbt.Execute$$anonfun$submit$1.apply(Execute.scala:226)
[info]   at sbt.ConcurrentRestrictions$$anon$4$$anonfun$1.apply(ConcurrentRestrictions.scala:159)
[info]   at sbt.CompletionService$$anon$2.call(CompletionService.scala:28)
[info]   at java.util.concurrent.FutureTask.run(FutureTask.java:266)
[info]   at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
[info]   at java.util.concurrent.FutureTask.run(FutureTask.java:266)
[info]   at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
[info]   at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
[info]   at java.lang.Thread.run(Thread.java:745)
[info] - should handle outers with constructors
[info] - should Handle functions in traits
[info] - should Handle captured vals

I'll see if I can manage to get a clearer stacktrace in order to figure out what's failing inside of the shaded ASM.

While Spark doesn't depend on Kryo's ClosureCleaner, it's likely that Spark's own ClosureCleaner (which is where Kryo's originated) has similar problems that will need to be addressed, so I'd like to try to take the chance to fix those problems here, too.

Build and publish against current Scala 2.12 milestone #252

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions