Skip to content

vendor multipart until https://github.com/defnull/multipart/issues/53 is addressed#400

Merged
twm merged 7 commits into
trunkfrom
vendor-multipart-for-now
Sep 19, 2024
Merged

vendor multipart until https://github.com/defnull/multipart/issues/53 is addressed#400
twm merged 7 commits into
trunkfrom
vendor-multipart-for-now

Conversation

@glyph

@glyph glyph commented Sep 19, 2024

Copy link
Copy Markdown
Member

this is an attempt at a minimally-invasive integration, modifying it just enough to get our lint to pass without changing too much about either the lint configuration or the vendored file.

Fixes #399

@glyph glyph requested a review from a team September 19, 2024 18:59
@twm

twm commented Sep 19, 2024

Copy link
Copy Markdown
Member

Very quickly, this looks fine but is missing a news fragment. I'll have time to review properly this afternoon. Thank you for jumping on this @glyph!

@glyph

glyph commented Sep 19, 2024

Copy link
Copy Markdown
Member Author

missing a news fragment

Didn't even realize we are using towncrier here; we should get a check into CI!

@twm twm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thank you again @glyph! I will go ahead and roll a release.

@twm twm merged commit 9cedb08 into trunk Sep 19, 2024
@twm twm deleted the vendor-multipart-for-now branch September 19, 2024 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

multipart dependency conflicts with python-multipart, making impossible to install treq and starlette on the same system

2 participants