Skip to content

#702 Skip mercurial tests if 'hg' not found#703

Merged
adiroiban merged 3 commits intotwisted:trunkfrom
cdevienne:skip-hg-tests
Apr 17, 2025
Merged

#702 Skip mercurial tests if 'hg' not found#703
adiroiban merged 3 commits intotwisted:trunkfrom
cdevienne:skip-hg-tests

Conversation

@cdevienne
Copy link
Copy Markdown
Contributor

@cdevienne cdevienne commented Apr 17, 2025

Fixes #702

This PR is in reply to #700 (comment)

Mercurial may be missing on some contributor computers. To avoid tests failing because of that, all the tests requiring mercurial are now skipped.

Skipping the tests lowers the coverage, which means the CI would not let this pass.

@cdevienne cdevienne requested a review from a team as a code owner April 17, 2025 12:53
@cdevienne cdevienne mentioned this pull request Apr 17, 2025
Mercurial may be missing on some contributor computers. To avoid tests
failing because of that, all the tests requiring mercurial are now
skipped.

Skipping the tests lowers the coverage, which means the CI would not let
this pass.
Copy link
Copy Markdown
Member

@adiroiban adiroiban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@adiroiban adiroiban changed the title Skip mercurial tests if 'hg' not found #702 Skip mercurial tests if 'hg' not found Apr 17, 2025
@adiroiban adiroiban enabled auto-merge April 17, 2025 13:04
@adiroiban adiroiban merged commit 32921c3 into twisted:trunk Apr 17, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Skip Mercurial tests if hg command is not available

2 participants