Skip to content

handle empty issue names#656

Merged
adiroiban merged 6 commits intotwisted:trunkfrom
dorschw:trunk
Aug 6, 2024
Merged

handle empty issue names#656
adiroiban merged 6 commits intotwisted:trunkfrom
dorschw:trunk

Conversation

@dorschw
Copy link
Copy Markdown
Contributor

@dorschw dorschw commented Aug 6, 2024

Description

Fixes #655

allow non-issue fragments when using issue_pattern.

Checklist

  • Make sure changes are covered by existing or new tests.
  • For at least one Python version, make sure test pass on your local environment.
  • Create a file in src/towncrier/newsfragments/. Briefly describe your
    changes, with information useful to end users. Your change will be included in the public release notes.
  • Make sure all GitHub Actions checks are green (they are automatically checking all of the above).

@dorschw dorschw requested a review from a team as a code owner August 6, 2024 14:38
Copy link
Copy Markdown
Member

@adiroiban adiroiban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Looks good.

Comment thread src/towncrier/newsfragments/655.bugfix.rst Outdated
@adiroiban adiroiban enabled auto-merge August 6, 2024 14:46
@adiroiban
Copy link
Copy Markdown
Member

Thanks for the update. Auto-merge was enabled.

auto-merge was automatically disabled August 6, 2024 14:48

Head branch was pushed to by a user without write access

Comment thread src/towncrier/test/test_check.py Outdated
@adiroiban adiroiban enabled auto-merge August 6, 2024 14:55
@adiroiban adiroiban merged commit 4aa8174 into twisted:trunk Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

no issue names are considered invalid when using issue_pattern

2 participants