Skip to content

Add .gitkeep as an ignored filename#647

Merged
adiroiban merged 5 commits intotwisted:trunkfrom
stevepiercy:patch-1
Aug 3, 2024
Merged

Add .gitkeep as an ignored filename#647
adiroiban merged 5 commits intotwisted:trunkfrom
stevepiercy:patch-1

Conversation

@stevepiercy
Copy link
Copy Markdown
Contributor

@stevepiercy stevepiercy commented Aug 3, 2024

Description

Fixes #643.

References #622.

Checklist

  • Make sure changes are covered by existing or new tests.
  • For at least one Python version, make sure test pass on your local environment.
  • Create a file in src/towncrier/newsfragments/. Briefly describe your
    changes, with information useful to end users. Your change will be included in the public release notes.
  • Make sure all GitHub Actions checks are green (they are automatically checking all of the above).
  • Ensure docs/tutorial.rst is still up-to-date.
  • If you add new CLI arguments (or change the meaning of existing ones), make sure docs/cli.rst reflects those changes.
  • If you add new configuration options (or change the meaning of existing ones), make sure docs/configuration.rst reflects those changes.

@stevepiercy stevepiercy requested a review from a team as a code owner August 3, 2024 04:43
Copy link
Copy Markdown
Member

@adiroiban adiroiban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update. It looks good.
I don't think that we need to update the test but maybe it would help to update the documentation to mention the new ignored file name.

@stevepiercy
Copy link
Copy Markdown
Contributor Author

Docs updated in d47c62e.

Copy link
Copy Markdown
Member

@adiroiban adiroiban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@adiroiban adiroiban enabled auto-merge August 3, 2024 14:24
@adiroiban adiroiban merged commit afa6cc0 into twisted:trunk Aug 3, 2024
@stevepiercy stevepiercy deleted the patch-1 branch August 3, 2024 18:57
@adiroiban adiroiban linked an issue Mar 16, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Release 24.8.0 Add .gitkeep as one of default valid filenames

2 participants