Skip to content

Release 23.11.0#566

Merged
adiroiban merged 5 commits intotrunkfrom
release-23.11.0
Nov 8, 2023
Merged

Release 23.11.0#566
adiroiban merged 5 commits intotrunkfrom
release-23.11.0

Conversation

@adiroiban
Copy link
Copy Markdown
Member

@adiroiban adiroiban commented Nov 7, 2023

@adiroiban adiroiban requested a review from a team as a code owner November 7, 2023 16:32
Comment thread .github/workflows/ci.yml
nox: check_newsfragment
run: |
nox -e check_newsfragment
nox -e draft_newsfragment >> $GITHUB_STEP_SUMMARY
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is to see the pending release note rendered

https://github.com/twisted/towncrier/actions/runs/6787483933#summary-18450436014

I hope it can help new contributors understand how the content of newsfragment is used.

In the future, we should have MD... but this is a first step.

Comment thread noxfile.py


@nox.session
def draft_newsfragment(session: nox.Session) -> None:
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went with nox, but I don't realy think we need this and check_newsfragment

but we can keep them for now

Copy link
Copy Markdown
Contributor

@iliakur iliakur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. can't really comment on the tooling changes tbh. the idea of having a preview of the changelog is cool!

@adiroiban
Copy link
Copy Markdown
Member Author

adiroiban commented Nov 8, 2023

@adiroiban adiroiban enabled auto-merge (squash) November 8, 2023 14:33
@adiroiban adiroiban merged commit 4d317bf into trunk Nov 8, 2023
@adiroiban adiroiban deleted the release-23.11.0 branch November 8, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants