Skip to content

Comments

Release 19.9.0#331

Merged
altendky merged 9 commits intomasterfrom
release-19.9.0
Mar 22, 2021
Merged

Release 19.9.0#331
altendky merged 9 commits intomasterfrom
release-19.9.0

Conversation

@altendky
Copy link
Member

@altendky altendky commented Mar 20, 2021

No description provided.

@altendky
Copy link
Member Author

altendky commented Mar 21, 2021

Proposed release artifacts (GitHub requires not-.whl so here is a .zip of the two).
towncrier-19.9.0-artifacts.zip

Being a special case here we're holding off on publishing until the next release is ready. Merge this first then publish it with the next release. See plan and discussion in #313.

@altendky altendky mentioned this pull request Mar 21, 2021
Closed
18 tasks
@altendky altendky requested a review from adiroiban March 21, 2021 00:39
@altendky altendky marked this pull request as ready for review March 21, 2021 00:40
adiroiban
adiroiban approved these changes Mar 21, 2021
View reviewed changes
Copy link
Member

@adiroiban adiroiban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

Please merge and create the tag.

As you mentioned, the PyPi zip will be uploaded after the 21.X.X release.

@codecov
Copy link

codecov bot commented Mar 21, 2021 •
edited
Loading

Codecov Report

Merging #331 (3b0b8ba) into master (7267fb5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #331   +/-   ##
=======================================
  Coverage   96.78%   96.78%           
=======================================
  Files          20       20           
  Lines        1183     1183           
  Branches      106      106           
=======================================
  Hits         1145     1145           
  Misses         20       20           
  Partials       18       18

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7267fb5...3b0b8ba. Read the comment docs.

@altendky altendky merged commit 2841c12 into master Mar 22, 2021
@altendky altendky deleted the release-19.9.0 branch March 22, 2021 00:11
@altendky altendky mentioned this pull request Mar 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adiroiban adiroiban adiroiban approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@altendky @adiroiban @hawkowl