Make check subcommand detect if only configured news file has changed#174
Closed
tjanez wants to merge 1 commit intotwisted:masterfrom
Closed
Make check subcommand detect if only configured news file has changed#174tjanez wants to merge 1 commit intotwisted:masterfrom
tjanez wants to merge 1 commit intotwisted:masterfrom
Conversation
This should enable the check subcommand to be used as a CI lint step and not fail when a pull request only modifies the configured news file (i.e. when the news file is being assembled for the next release).
ghost
mentioned this pull request
2 tasks
Member
|
If you get back to this before I manage to find some reviews, feel free to merge #296 back in here and we can continue with this PR and close mine. I just didn't want to hijack your branch. Thanks again. |
Member
|
I think that this can be closed as the code was moved to #296 where tests were added. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should enable the
checksubcommand to be used as a CI lint step and not fail when a pull request only modifies the configured news file (i.e. when the news file is being assembled for the next release).Closes #152.