Repository navigation
Conversation
seberg
force-pushed
the
optional-pyproject
branch
from
July 17, 2019 21:09
c8abebe to
9354e2d
Compare
Codecov Report
@@ Coverage Diff @@
## master #156 +/- ##
========================================
- Coverage 93.29% 93% -0.29%
========================================
Files 15 15
Lines 626 629 +3
Branches 65 66 +1
========================================
+ Hits 584 585 +1
- Misses 26 27 +1
- Partials 16 17 +1
Continue to review full report at Codecov.
|
This adds `--pyproject` to `towncrier`, the same way as what exists for `towncrier.check`. Closes twistedgh-148
seberg
force-pushed
the
optional-pyproject
branch
from
July 18, 2019 02:08
9354e2d to
5d1a830
Compare
Author
|
xref gh-157 which solves the same issue (uses |
webknjaz
approved these changes
Aug 5, 2019
Member
|
I merged 157, I prefer the config name over pyproject (since pyproject is python specific). Thanks! |
Author
|
I agree config is nicer, could change |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds
--pyprojecttotowncrier, the same way as what existsfor
towncrier.check.This probably needs a few additional things (such as tests)? I tried it locally briefly, and it seems to work (is pretty straight forward after all).