check for return type#4721
Closed
tacman wants to merge 3 commits into
Closed
Conversation
xabbuh
suggested changes
Dec 3, 2025
| public function build(ContainerBuilder $container): void | ||
| { | ||
| parent::build($container); | ||
|
|
| public function build(ContainerBuilder $container) | ||
| { | ||
| parent::build($container); | ||
|
|
| } | ||
| } | ||
| } | ||
|
|
Co-authored-by: Christian Flothmann <[email protected]>
Co-authored-by: Christian Flothmann <[email protected]>
stof
reviewed
Dec 3, 2025
| use Twig\Extra\TwigExtraBundle\DependencyInjection\Compiler\MissingExtensionSuggestorPass; | ||
|
|
||
| if (!method_exists(ContainerBuilder::class, 'getAutoconfiguredAttributes')) { | ||
| $refMethod = new \ReflectionMethod(\Symfony\Component\HttpKernel\Bundle\Bundle::class, 'build'); |
Member
There was a problem hiding this comment.
Should be removed as this is unused.
Contributor
Author
|
OK, perhaps it's better to start with a new PR that just checks for major version? Basically just changing the if condition. |
Member
you can do a force push to your branch to change its history if you want. No need to replace the PR itself. |
Contributor
Author
|
replaced by #4722 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this captures what we actually want to check for.