Add missing import#4456
Merged
Merged
Conversation
Contributor
|
Thank you @VincentLanglet. |
Contributor
|
@fabpot Would it be an idea to set-up PHPStan for this project? This could have been detected earlier. |
Merged
fabpot
added a commit
that referenced
this pull request
Nov 20, 2024
This PR was squashed before being merged into the 3.x branch. Discussion ---------- Add phpstan analysis As suggested by `@ruudk` here: #4456 (comment) I think it could be useful to add phpstan analysis on twig. This is an example of all the things reported when checking level 3 PHPStan (more will get more errors to fix). Commits ------- 75d48db Add phpstan analysis
|
@fabpot when is this fix coming in a tag? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @fabpot, the phpdoc was updated in #4367 but the import was forgotten.
This leads to an error with all static analysis tools when implementing ExtensionInterface.
If possible a patch version would be helpful.
(Tests are already failing on 3.x)