Trigger deprecations when using "??" and "not" without explicit parentheses when precedence will change in 4.0#4367
Merged
Conversation
fabpot
force-pushed
the
NullCoalesceExpression-precedence
branch
from
September 30, 2024 14:44
385fe86 to
afcfdee
Compare
stof
reviewed
Sep 30, 2024
Member
There was a problem hiding this comment.
I'm wondering whether this could be implemented in the ExpressionParser while resolving precedence (by providing a future_precedence or something like that) instead of inspecting the AST after the fact. This could make it work in combination with third-party operators as well (which might have a precedence between the old and new ones and so be impacted).
| {{ nope ?? nada ?? 'OK' }} | ||
| {{ 1 + nope ?? nada ?? 2 }} | ||
| {{ 1 + nope ?? 3 + nada ?? 2 }} | ||
| {{ nope ?? (nada ?? 'OK') }} |
Member
There was a problem hiding this comment.
should we really report this case ? It will be parsed the same in 4.0
fabpot
force-pushed
the
NullCoalesceExpression-precedence
branch
from
October 1, 2024 13:00
afcfdee to
320751b
Compare
Contributor
Author
|
@stof I've rewritten how this all works. It's now all automated in the sense that it's done in a generic way where I just need the current and future precedence. It's a quick prototype I've done in a few minutes, so I might have forgotten something. Can you have a look? |
fabpot
force-pushed
the
NullCoalesceExpression-precedence
branch
7 times, most recently
from
October 2, 2024 07:13
9662b54 to
b0249b6
Compare
fabpot
changed the title
fabpot
force-pushed
the
NullCoalesceExpression-precedence
branch
from
October 2, 2024 07:17
b0249b6 to
1acb004
Compare
fabpot
changed the title
fabpot
force-pushed
the
NullCoalesceExpression-precedence
branch
from
October 2, 2024 07:19
1acb004 to
69e0b0f
Compare
Contributor
Author
|
The implementation is now much better. I'm done for this PR. |
stof
reviewed
Oct 2, 2024
fabpot
force-pushed
the
NullCoalesceExpression-precedence
branch
from
October 2, 2024 11:11
69e0b0f to
c726b99
Compare
stof
reviewed
Oct 2, 2024
fabpot
force-pushed
the
NullCoalesceExpression-precedence
branch
from
October 2, 2024 11:58
c726b99 to
877c055
Compare
stof
approved these changes
Oct 2, 2024
stof
reviewed
Oct 2, 2024
| * Deprecate using `~` with `+` or `-` in an expression without using parentheses to clarify precedence | ||
| * Deprecate using the `not` unary operator in an expression with ``*``, ``/``, ``//``, or ``%`` without using explicit parentheses to clarify precedence | ||
| * Deprecate using the `??` binary operator without explicit parentheses | ||
| * Deprecate using the `~` binary operator in an expression with `+` or `-` without using parentheses to clarify precedence |
Member
There was a problem hiding this comment.
this should also mention Add support for triggering deprecations for future operator precedence changes (and maybe this should have docymentation as well)
fabpot
force-pushed
the
NullCoalesceExpression-precedence
branch
from
October 2, 2024 12:16
877c055 to
2081b1f
Compare
Merged
fabpot
added a commit
that referenced
this pull request
Nov 20, 2024
This PR was merged into the 3.x branch. Discussion ---------- Add missing import Hi `@fabpot`, the phpdoc was updated in #4367 but the import was forgotten. This leads to an error with all static analysis tools when implementing ExtensionInterface. If possible a patch version would be helpful. (Tests are already failing on 3.x) Commits ------- 51d10ba Add missing import
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3387
Closes #3642