feat: private key with passphrase #166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khalidmaquilang
suggested changes
Sep 3, 2025
Contributor
|
Can't wait for this to get merge! |
Co-authored-by: khalidmaquilang <[email protected]>
khalidmaquilang
approved these changes
Sep 6, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for SSH private key authentication with passphrase protection, addressing the need to connect to hosts that use encrypted private keys.
- Added passphrase field to the SSH connection configuration interface
- Enhanced the SSH connection form to include a passphrase input field for key-based authentication
- Updated SSH connection logic to handle passphrase-protected private keys
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/types/ssh.type.ts | Added passphrase field to ConnectionConfig interface |
| src/renderer/views/SSHConnectView.vue | Added passphrase input field in the SSH connection form |
| src/main/utils/ssh.ts | Updated SSH configuration to support passphrase and authentication handlers |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Comment on lines
+18
to
+19
| passphrase: '', | ||
| authHandler: undefined, |
There was a problem hiding this comment.
The authHandler property is being added to the config object but it's not defined in the type definition. This could cause TypeScript compilation errors or runtime issues if the SSH client expects a specific type for this property.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the possibility to connect by ssh to host with private key with passphrase
fixes #146