Update to Bazel 2.1#108
Merged
thufschmitt merged 2 commits intomasterfrom Mar 9, 2020
Merged
Conversation
Toolchain resolution of the Python toolchain erroneously picked the autodetecting toolchain instead of the nixpkgs provided toolchain. Debugging with `--toolchain_resolution_debug` shows the following error: ``` Toolchain constraint @bazel_tools//tools/cpp:cc_compiler has value //nixpkgs/constraints:nixpkgs, which does not match value @io_tweag_rules_nixpkgs//nixpkgs/constraints:nixpkgs from the execution platform @io_tweag_rules_nixpkgs//nixpkgs/constraints:linux_x86_64_nixpkgs ``` The issue is that Bazel (tested at version 2.1) considers `//nixpkgs/constraints:nixpkgs` and `@io_tweag_rules_nixpkgs//nixpkgs/constraints:nixpkgs` two different values, even though they refer to the same target.
This was referenced Mar 9, 2020
thufschmitt
approved these changes
Mar 9, 2020
Contributor
thufschmitt
left a comment
thufschmitt
left a comment
There was a problem hiding this comment.
Awesome, thanks
Tested that locally and everything is green
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
//nixpkgs/constraints:nixpkgsand@io_tweag_rules_nixpkgs//nixpkgs/constraints:nixpkgstwo different values, even though they refer to the same target.