Declare font-size mixin for Less and add tests for font-size mixin#129
Conversation
|
Good point! It seems like the The tests for this PR failed for
Which means the font-size property always is overridden by the font-size mixin. We could probably fix this by using So we got 2 options for Stylus:
For less everything looks ok. We still need to add some tests, but the implementation depends on the direction we take with Stylus. |
That is a bummer. I don't think overwriting the font-size property is a good idea, one of the main reasons I was eager to adopt rfs is because you can adopt it "incrementally", that is, without breaking fonts that you've previously made responsive manually, for example. But there may be other things to consider. In the meantime, I've removed the font-size mixin from the Stylus file and I've written the tests for the font-size mixin. I don't know if that is the best way to write them, what do you think? |
MartijnCuppens
left a comment
There was a problem hiding this comment.
I don't know if that is the best way to write them, what do you think?
This is the best way I guess. Thanks for also taking care of the tests, @tsilvap!
See #129 (comment) for additional info
* Remove font-size mixin in docs for stylus See #129 (comment) for additional info
The font-size mixin doesn't work for Less and Stylus right now because it was never declared.