Mention npm install and npm run dist in CONTRIBUTING.md#41340
Merged
julien-deramond merged 4 commits intomainfrom Apr 7, 2025
Merged
Mention npm install and npm run dist in CONTRIBUTING.md#41340julien-deramond merged 4 commits intomainfrom
npm install and npm run dist in CONTRIBUTING.md#41340julien-deramond merged 4 commits intomainfrom
Conversation
10 tasks
mdo
changed the title
npm install and npm run dist in CONTRIBUTING.md
Member
julien-deramond
left a comment
julien-deramond
left a comment
There was a problem hiding this comment.
The modifications sound nice, I've just added a comment to avoid having dist and js/dist files in the PRs.
julien-deramond
approved these changes
Apr 7, 2025
This was referenced Aug 19, 2025
This was referenced Aug 26, 2025
This was referenced Sep 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Much simpler approach than #41333. Fixes #41209.