Skip to content

Docs: Use <article> element for example cards#40965

Merged
patrickhlauke merged 2 commits intotwbs:mainfrom
coliff:dev/coliff/docs-examples-article
Dec 10, 2024
Merged

Docs: Use <article> element for example cards#40965
patrickhlauke merged 2 commits intotwbs:mainfrom
coliff:dev/coliff/docs-examples-article

Conversation

@coliff
Copy link
Copy Markdown
Contributor

@coliff coliff commented Oct 22, 2024 •
edited
Loading

Description & Motivation & Context

This makes semantic sense.

REF: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/article

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

@coliff coliff changed the title Docs; Use <article> element for example cards Docs: Use <article> element for example cards Oct 22, 2024
@julien-deramond julien-deramond requested a review from a team October 22, 2024 12:25
louismaximepiton
louismaximepiton approved these changes Oct 24, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@louismaximepiton louismaximepiton left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!
On my side, I'm fine with it, any thoughts @patrickhlauke ?

@patrickhlauke patrickhlauke merged commit ff7d1be into twbs:main Dec 10, 2024
@coliff coliff deleted the dev/coliff/docs-examples-article branch December 10, 2024 12:04
@patrickhlauke
Copy link
Copy Markdown
Member

patrickhlauke commented Dec 10, 2024

In practical terms, this doesn't really matter all too much (from a quick check, NVDA doesn't announce articles, though JAWS does), but sure...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@louismaximepiton louismaximepiton louismaximepiton approved these changes

@patrickhlauke patrickhlauke Awaiting requested review from patrickhlauke

Assignees

No one assigned

Labels

accessibility docs enhancement v5

Projects

No open projects
v5.3.4
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@coliff @patrickhlauke @louismaximepiton @julien-deramond