Docs: minor accessibility improvements for Examples#40620
Merged
julien-deramond merged 2 commits intotwbs:mainfrom Jul 19, 2024
Merged
Docs: minor accessibility improvements for Examples#40620julien-deramond merged 2 commits intotwbs:mainfrom
julien-deramond merged 2 commits intotwbs:mainfrom
Conversation
- no need for `role="document"` on modals (was removed from Bootstrap a while ago) - use `type="email"` for email input - Add aria-labels for previous month and next month buttons on date picker demo
louismaximepiton
approved these changes
Jul 18, 2024
Member
louismaximepiton
left a comment
louismaximepiton
left a comment
There was a problem hiding this comment.
LGTM regarding #30755, thanks for the PR 🚀
patrickhlauke
approved these changes
Jul 18, 2024
julien-deramond
approved these changes
Jul 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
role="document"on modals (was removed from Bootstrap a while ago)type="email"for email inputMotivation & Context
Helpful for folks copying and pasting to their own templates to have more accessible code
Type of changes
Checklist
npm run lint)Live previews
Related issues