Docs: Fix a minor accessibility issue (checkout example missing h1)#40619
Merged
julien-deramond merged 1 commit intotwbs:mainfrom Jul 10, 2024
Merged
Docs: Fix a minor accessibility issue (checkout example missing h1)#40619julien-deramond merged 1 commit intotwbs:mainfrom
julien-deramond merged 1 commit intotwbs:mainfrom
Conversation
…ing) This is a best practice and not an error, though still worth fixing I think. REF: https://dequeuniversity.com/rules/axe/4.9/page-has-heading-one?application=AxeEdge
julien-deramond
approved these changes
Jul 9, 2024
Member
julien-deramond
left a comment
julien-deramond
left a comment
There was a problem hiding this comment.
Good catch, thanks for this patch @coliff. I'll assign it to @patrickhlauke for a double-check.
patrickhlauke
approved these changes
Jul 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a best practice and not an error or warning, though still worth fixing I think.
REF: https://dequeuniversity.com/rules/axe/4.9/page-has-heading-one?application=AxeEdge
Description
Changed the h2 to a h1
Motivation & Context
To reduce the numbers of issues reported by Axe Core Accessibilty test
Type of changes
Checklist
npm run lint)Live previews
Related issues