Collapse: Fix multiple `id`s calls by louismaximepiton · Pull Request #38989 · twbs/bootstrap

louismaximepiton · 2023-08-01T08:13:21Z

Description

With git bisect, it seems the breaking change appeared from #37438.
The only change in here was that the parseSelector was applied in any case and not on some specific cases anymore. Reverting this change.

Motivation & Context

Break some (wrong?) use cases.

Type of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Refactoring (non-breaking change)
Breaking change (fix or feature that would change existing functionality)

Checklist

I have read the contributing guidelines
My code follows the code style of the project (using npm run lint)
My change introduces changes to the documentation
I have updated the documentation accordingly
I have added tests to cover my changes
All new and existing tests passed

Live previews

https://deploy-preview-38989--twbs-bootstrap.netlify.app/

Tried it with the minimal code:

<button data-bs-toggle="collapse" data-bs-target="#hello,#world">
  collapse
</button>

<div id="hello" class="collapse">HELLO</div>
<div id="world" class="collapse">WORLD</div>

Related issues

Closes #38974.

XhmikosR · 2023-08-01T08:18:12Z

Nice git bisecting!

Confirmed it fixes #38974. @GeoSot LGTY?

XhmikosR · 2023-08-01T18:18:31Z

As for the tests, yeah, ideally we should have one, because apparently it's not covered by the existent tests :)

Parasuramragu

its an clear review in this program
I had checked the program in this compailer in this program and i have check the program in VS Code

julien-deramond

Nice analysis 💪 LGTM!

* fix: regression of #38989 * Add unit test in selector-engine.spec.js --------- Co-authored-by: Julien Déramond <[email protected]> Co-authored-by: XhmikosR <[email protected]>

Fix collapse multiple ids

89489cd

louismaximepiton added js v5 labels Aug 1, 2023

louismaximepiton requested a review from a team as a code owner August 1, 2023 08:13

Add test case for multiple ids

cbfc4a1

Parasuramragu reviewed Aug 7, 2023

View reviewed changes

XhmikosR requested a review from GeoSot August 22, 2023 08:27

XhmikosR and others added 2 commits August 22, 2023 11:27

Merge branch 'main' into main-lmp-fix-multi-ids

dd066fb

Merge branch 'main' into main-lmp-fix-multi-ids

4170724

julien-deramond approved these changes Sep 13, 2023

View reviewed changes

julien-deramond merged commit 9900cf3 into main Sep 13, 2023

julien-deramond deleted the main-lmp-fix-multi-ids branch September 13, 2023 07:30

XhmikosR changed the title ~~Collapse: Fix multiple ids calls~~ Collapse: Fix multiple ids calls Sep 14, 2023

XhmikosR mentioned this pull request Sep 15, 2023

invalid selector regression in 5.3.2 #39189

Closed

3 tasks

GeoSot added a commit that referenced this pull request Sep 17, 2023

fix: regression of #38989

9ecd29c

GeoSot mentioned this pull request Sep 17, 2023

Selector Engine: fix multiple IDs #39201

Merged

10 tasks

GeoSot added a commit that referenced this pull request Sep 18, 2023

fix: regression of #38989

f8fc167

romankupchak93 pushed a commit to romankupchak93/bootstrap that referenced this pull request Jan 5, 2024

Fix collapse multiple ids target (twbs#38989)

7c68587

GeoSot added a commit that referenced this pull request Feb 9, 2024

fix: regression of #38989

4b0dd2b

GeoSot added a commit that referenced this pull request Feb 13, 2024

fix: regression of #38989

c10892b

CGrabda mentioned this pull request May 17, 2024

[Snyk] Upgrade bootstrap from 5.3.2 to 5.3.3 CGrabda/drawBetterCards#18

Merged

RatanaSenpai mentioned this pull request May 18, 2024

[Snyk] Upgrade bootstrap from 5.3.2 to 5.3.3 RatanaSenpai/La_Panthere#393

Open

lukegeor mentioned this pull request May 18, 2024

[Snyk] Upgrade bootstrap from 5.2.3 to 5.3.3 lukegeor/insecure-project-snyk#2

Open

RatanaSenpai mentioned this pull request May 19, 2024

[Snyk] Upgrade bootstrap from 5.3.2 to 5.3.3 RatanaSenpai/La_Panthere#395

Open

This was referenced May 19, 2024

[Snyk] Upgrade bootstrap from 5.3.2 to 5.3.3 Identian/intra#5

Open

[Snyk] Upgrade bootstrap from 5.2.2 to 5.3.3 Identian/main#4

Open

RatanaSenpai mentioned this pull request May 19, 2024

[Snyk] Upgrade bootstrap from 5.3.2 to 5.3.3 RatanaSenpai/La_Panthere#397

Open

RatanaSenpai mentioned this pull request Sep 29, 2024

[Snyk] Upgrade bootstrap from 5.3.2 to 5.3.3 RatanaSenpai/La_Panthere#637

Open

DeFiTON mentioned this pull request Sep 30, 2024

[Snyk] Upgrade bootstrap from 5.3.2 to 5.3.3 TegroTON/Tegro-Media-Source-project-file-for-SMM-Store#36

Open

lisagorewitdecker mentioned this pull request Sep 30, 2024

[Snyk] Upgrade bootstrap from 5.0.0 to 5.3.3 lisagorewitdecker/Angular2023-to-1-2-Quarter-2024#669

Merged

YnnusAsamal mentioned this pull request Sep 30, 2024

[Snyk] Upgrade bootstrap from 5.2.0 to 5.3.3 YnnusAsamal/TTI-NRL-WEB#3

Open

RatanaSenpai mentioned this pull request Sep 30, 2024

[Snyk] Upgrade bootstrap from 5.3.2 to 5.3.3 RatanaSenpai/La_Panthere#639

Open

YnnusAsamal mentioned this pull request Oct 1, 2024

[Snyk] Upgrade bootstrap from 5.2.0 to 5.3.3 YnnusAsamal/TTI-NRL-WEB#4

Open

RatanaSenpai mentioned this pull request Oct 1, 2024

[Snyk] Upgrade bootstrap from 5.3.2 to 5.3.3 RatanaSenpai/La_Panthere#641

Open

Akhamesra mentioned this pull request Oct 2, 2024

[Snyk] Upgrade bootstrap from 5.1.3 to 5.3.3 Akhamesra/glpi#5

Open

This was referenced Oct 2, 2024

[Snyk] Upgrade bootstrap from 5.3.2 to 5.3.3 RatanaSenpai/La_Panthere#643

Open

[Snyk] Upgrade bootstrap from 5.3.2 to 5.3.3 RatanaSenpai/La_Panthere#645

Open

YnnusAsamal mentioned this pull request Oct 3, 2024

[Snyk] Upgrade bootstrap from 5.2.0 to 5.3.3 YnnusAsamal/TTI-NRL-WEB#5

Open

RatanaSenpai mentioned this pull request Oct 4, 2024

[Snyk] Upgrade bootstrap from 5.3.2 to 5.3.3 RatanaSenpai/La_Panthere#647

Open

jtprogru mentioned this pull request Oct 5, 2024

[Snyk] Upgrade bootstrap from 5.1.3 to 5.3.3 jtprogru/s11l.me#33

Open

Gutts-n mentioned this pull request Oct 5, 2024

[Snyk] Upgrade bootstrap from 5.1.3 to 5.3.3 datopian/ckan#3

Open

Kimahari mentioned this pull request Oct 5, 2024

[Snyk] Upgrade bootstrap from 5.0.0 to 5.3.3 Kimahari/nginx-dotnetcore-proxy#73

Merged

This was referenced Oct 5, 2024

[Snyk] Upgrade bootstrap from 5.3.2 to 5.3.3 RatanaSenpai/La_Panthere#649

Open

[Snyk] Upgrade bootstrap from 5.3.2 to 5.3.3 RatanaSenpai/La_Panthere#651

Open

This was referenced Oct 12, 2024

[Snyk] Upgrade bootstrap from 5.3.0 to 5.3.3 eronisking/Vf#2

Open

[Snyk] Upgrade bootstrap from 5.3.0 to 5.3.3 eronisking/Adminkit#2

Open

RatanaSenpai mentioned this pull request Oct 13, 2024

[Snyk] Upgrade bootstrap from 5.3.2 to 5.3.3 RatanaSenpai/La_Panthere#653

Open

This was referenced Oct 15, 2024

[Snyk] Upgrade bootstrap from 5.3.0 to 5.3.3 eronisking/vf-#2

Open

[Snyk] Upgrade bootstrap from 5.3.0 to 5.3.3 eronisking/adminkit1#1

Open

RatanaSenpai mentioned this pull request Oct 20, 2024

[Snyk] Upgrade bootstrap from 5.3.2 to 5.3.3 RatanaSenpai/La_Panthere#655

Open

Sarrac3873 mentioned this pull request Oct 22, 2024

[Snyk] Upgrade bootstrap from 5.3.2 to 5.3.3 Sarrac3873/icu4x#5

Open

RatanaSenpai mentioned this pull request Oct 27, 2024

[Snyk] Upgrade bootstrap from 5.3.2 to 5.3.3 RatanaSenpai/La_Panthere#657

Open

This was referenced Oct 29, 2024

[Snyk] Upgrade bootstrap from 5.3.2 to 5.3.3 TegroTON/Tegro-Media-Source-project-file-for-SMM-Store#37

Open

[Snyk] Upgrade bootstrap from 5.3.2 to 5.3.3 TegroTON/Tegro-Media-Source-project-file-for-SMM-Store#38

Open

RatanaSenpai mentioned this pull request Nov 3, 2024

[Snyk] Upgrade bootstrap from 5.3.2 to 5.3.3 RatanaSenpai/La_Panthere#659

Open

Arrhenius09 mentioned this pull request Nov 6, 2024

[Snyk] Upgrade bootstrap from 5.0.0 to 5.3.3 Arrhenius09/sonarqube-sample#2

Open

RatanaSenpai mentioned this pull request Nov 10, 2024

[Snyk] Upgrade bootstrap from 5.3.2 to 5.3.3 RatanaSenpai/La_Panthere#661

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Collapse: Fix multiple `id`s calls#38989

Collapse: Fix multiple `id`s calls#38989
julien-deramond merged 4 commits intomainfrom
main-lmp-fix-multi-ids

louismaximepiton commented Aug 1, 2023 •

edited by julien-deramond

Loading

Uh oh!

XhmikosR commented Aug 1, 2023

Uh oh!

XhmikosR commented Aug 1, 2023

Uh oh!

Parasuramragu left a comment

Uh oh!

julien-deramond left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

louismaximepiton commented Aug 1, 2023 • edited by julien-deramond Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Motivation & Context

Type of changes

Checklist

Live previews

Related issues

Uh oh!

XhmikosR commented Aug 1, 2023

Uh oh!

XhmikosR commented Aug 1, 2023

Uh oh!

Parasuramragu left a comment

Choose a reason for hiding this comment

Uh oh!

julien-deramond left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

louismaximepiton commented Aug 1, 2023 •

edited by julien-deramond

Loading