Skip to content

Floating labels: fix disabled with text inside#38913

Merged
mdo merged 1 commit intomainfrom
main-lmp-fix-disabled-floating-label
Jul 24, 2023
Merged

Floating labels: fix disabled with text inside#38913
mdo merged 1 commit intomainfrom
main-lmp-fix-disabled-floating-label

Conversation

@louismaximepiton
Copy link
Copy Markdown
Member

@louismaximepiton louismaximepiton commented Jul 17, 2023 •
edited
Loading

Description

Add a rule to add more specifity on disabled rule.
Add some text inside one of our exemple since it doesn't overlap anything and help for the support.

Motivation & Context

Asked by community

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • (NA) I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

Fixes #38731.

@louismaximepiton louismaximepiton requested a review from a team as a code owner July 17, 2023 10:13
@mdo mdo merged commit cc5a8a9 into main Jul 24, 2023
@mdo mdo deleted the main-lmp-fix-disabled-floating-label branch July 24, 2023 04:41
@XhmikosR
Copy link
Copy Markdown
Member

XhmikosR commented Jul 24, 2023

@louismaximepiton that's why I said the other day to fix your commit messages 😛

image

@mdo
Copy link
Copy Markdown
Member

mdo commented Jul 25, 2023

Fwiw I don’t care about commit messages haha. It’s the references PRs and issues I care more about. As long as we have that, we’re usually good :).

@lukegeor lukegeor mentioned this pull request May 18, 2024
Open
This was referenced May 19, 2024
Open
Open
@Hamberfim Hamberfim mentioned this pull request May 21, 2024
Merged
@V1CTORY360 V1CTORY360 mentioned this pull request May 22, 2024
Open
This was referenced May 24, 2024
Open
Open
@devcurt696 devcurt696 mentioned this pull request May 24, 2024
Open
@nejidevelops nejidevelops mentioned this pull request May 24, 2024
Open
@Guiguiiz92 Guiguiiz92 mentioned this pull request May 24, 2024
Open
@Cpano Cpano mentioned this pull request May 24, 2024
Open
@zxcv32 zxcv32 mentioned this pull request May 24, 2024
Open
@V1CTORY360 V1CTORY360 mentioned this pull request May 24, 2024
Open
This was referenced May 24, 2024
Open
Open
@ngochoangg ngochoangg mentioned this pull request May 24, 2024
Open
@jadsongmatos jadsongmatos mentioned this pull request May 24, 2024
Open
@bich-samrouth bich-samrouth mentioned this pull request May 24, 2024
Open
@RodolfoBorbon RodolfoBorbon mentioned this pull request May 24, 2024
Open
@SherfeyInv SherfeyInv mentioned this pull request May 25, 2024
Merged
@Avneesh-Rajput Avneesh-Rajput mentioned this pull request May 25, 2024
Open
@irklva irklva mentioned this pull request May 25, 2024
Open
@GTVolk GTVolk mentioned this pull request Sep 14, 2024
Open
@ramachoon ramachoon mentioned this pull request Sep 15, 2024
Open
@Cpano Cpano mentioned this pull request Sep 17, 2024
Open
@GTVolk GTVolk mentioned this pull request Sep 17, 2024
Open
@Cpano Cpano mentioned this pull request Sep 18, 2024
Open
This was referenced Sep 18, 2024
Open
Open
Open
Open
Open
This was referenced Sep 24, 2024
Open
Open
Open
Open
@pinco227 pinco227 mentioned this pull request Sep 27, 2024
Open
This was referenced Sep 28, 2024
Open
Open
@lisagorewitdecker lisagorewitdecker mentioned this pull request Sep 30, 2024
Merged
This was referenced Sep 30, 2024
Open
Open
@Akhamesra Akhamesra mentioned this pull request Oct 2, 2024
Open
@YnnusAsamal YnnusAsamal mentioned this pull request Oct 3, 2024
Open
@jtprogru jtprogru mentioned this pull request Oct 5, 2024
Open
@Gutts-n Gutts-n mentioned this pull request Oct 5, 2024
Open
@Kimahari Kimahari mentioned this pull request Oct 5, 2024
Merged
This was referenced Oct 12, 2024
Open
Open
Open
Open
@Arrhenius09 Arrhenius09 mentioned this pull request Nov 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

css v5

Projects

No open projects
v5.3.1
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

v5.3.0 Broken floating label background for disabled Input[type=text] and textarea

3 participants

@louismaximepiton @XhmikosR @mdo