New Sass variable to change vertical rule width#38886
Merged
Conversation
julien-deramond
force-pushed
the
main-jd-vertical-rule-sass-variable
branch
from
03260c7 to
a355cad
Compare
simo026q
reviewed
Jul 12, 2023
There was a problem hiding this comment.
How about adding a new variable called $rule-border-width?
$rule-border-width: var(--#{$prefix}border-width) !default;
$hr-border-width: $rule-border-width !default;
$vr-border-width: $rule-border-width !default;You could also do the same with the $hr-opacity since you most likely don't know it's used by the vertical rule without looking at the implementation. But that should maybe be another PR
mdo
approved these changes
Jul 17, 2023
Member
|
Oops, meant to merge another branch. Oh well, this is probably fine to be in v5.3.1 anyway even though technically it's a new Sass variable. |
This was referenced May 19, 2024
This was referenced May 24, 2024
This was referenced May 24, 2024
This was referenced Sep 18, 2024
This was referenced Sep 24, 2024
This was referenced Sep 28, 2024
This was referenced Sep 30, 2024
This was referenced Oct 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new Sass variable (
$vr-border-width) to customize the width of the vertical rule helper.Motivation & Context
Vertical rule helper should offer the same customization options as horizontal rule helper.
IMO, this new feature, if landed, should target v5.4.0.
Type of changes
Checklist
npm run lint)Live previews
Related issues
Closes #38856