Skip to content

Fix Sass properties order for newer stylelint-config-recess-order#38851

Merged
XhmikosR merged 1 commit intomainfrom
xmr/scss-order
Jun 30, 2023
Merged

Fix Sass properties order for newer stylelint-config-recess-order#38851
XhmikosR merged 1 commit intomainfrom
xmr/scss-order

Conversation

@XhmikosR
Copy link
Copy Markdown
Member

@XhmikosR XhmikosR commented Jun 30, 2023 •
edited
Loading

Description

Motivation & Context

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

@XhmikosR XhmikosR added the css label Jun 30, 2023
@XhmikosR XhmikosR marked this pull request as ready for review June 30, 2023 06:13
@XhmikosR XhmikosR requested a review from a team as a code owner June 30, 2023 06:13
julien-deramond
julien-deramond approved these changes Jun 30, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modification looks good to me.
This is a preparation for an update of stylelint-config-twbs-bootstrap? Because the linter is already happy with the content of the main branch.

@XhmikosR
Copy link
Copy Markdown
Member Author

XhmikosR commented Jun 30, 2023

It's a minor stylelint-config-recess-order version bump that's causing the new issues, so technically without a lock file we'd see the issues here too.

I'll make it a major stylelint-config-twbs-bootstrap bump just to be safe, though.

@XhmikosR XhmikosR merged commit 1ab75c8 into main Jun 30, 2023
@XhmikosR XhmikosR deleted the xmr/scss-order branch June 30, 2023 06:52
romankupchak93 pushed a commit to romankupchak93/bootstrap that referenced this pull request Jan 5, 2024
@XhmikosR @romankupchak93
Fix Sass properties order for newer stylelint-config-recess-order (tw…
a491329 
…bs#38851)
@lukegeor lukegeor mentioned this pull request May 18, 2024
Open
This was referenced May 19, 2024
Open
Open
@Hamberfim Hamberfim mentioned this pull request May 21, 2024
Merged
@V1CTORY360 V1CTORY360 mentioned this pull request May 22, 2024
Open
This was referenced May 24, 2024
Open
Open
@devcurt696 devcurt696 mentioned this pull request May 24, 2024
Open
@nejidevelops nejidevelops mentioned this pull request May 24, 2024
Open
@Guiguiiz92 Guiguiiz92 mentioned this pull request May 24, 2024
Open
@Cpano Cpano mentioned this pull request May 24, 2024
Open
@zxcv32 zxcv32 mentioned this pull request May 24, 2024
Open
@V1CTORY360 V1CTORY360 mentioned this pull request May 24, 2024
Open
This was referenced May 24, 2024
Open
Open
@ngochoangg ngochoangg mentioned this pull request May 24, 2024
Open
@jadsongmatos jadsongmatos mentioned this pull request May 24, 2024
Open
@bich-samrouth bich-samrouth mentioned this pull request May 24, 2024
Open
@RodolfoBorbon RodolfoBorbon mentioned this pull request May 24, 2024
Open
@SherfeyInv SherfeyInv mentioned this pull request May 25, 2024
Merged
@GTVolk GTVolk mentioned this pull request Sep 14, 2024
Open
@ramachoon ramachoon mentioned this pull request Sep 15, 2024
Open
@Cpano Cpano mentioned this pull request Sep 17, 2024
Open
@GTVolk GTVolk mentioned this pull request Sep 17, 2024
Open
@Cpano Cpano mentioned this pull request Sep 18, 2024
Open
This was referenced Sep 18, 2024
Open
Open
Open
Open
Open
This was referenced Sep 24, 2024
Open
Open
Open
Open
@pinco227 pinco227 mentioned this pull request Sep 27, 2024
Open
This was referenced Sep 28, 2024
Open
Open
@lisagorewitdecker lisagorewitdecker mentioned this pull request Sep 30, 2024
Merged
This was referenced Sep 30, 2024
Open
Open
@Akhamesra Akhamesra mentioned this pull request Oct 2, 2024
Open
@YnnusAsamal YnnusAsamal mentioned this pull request Oct 3, 2024
Open
@jtprogru jtprogru mentioned this pull request Oct 5, 2024
Open
@Gutts-n Gutts-n mentioned this pull request Oct 5, 2024
Open
@Kimahari Kimahari mentioned this pull request Oct 5, 2024
Merged
This was referenced Oct 12, 2024
Open
Open
Open
Open
@Arrhenius09 Arrhenius09 mentioned this pull request Nov 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@julien-deramond julien-deramond julien-deramond approved these changes

Assignees

No one assigned

Labels

css

Projects

No open projects
v5.3.1
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@XhmikosR @julien-deramond