Use box-shadow CSS variables shadow utilities#38816
Merged
julien-deramond merged 2 commits intotwbs:mainfrom Jul 27, 2023
craigiswayne:feature/box-shadow-css-variables
Merged
Use box-shadow CSS variables shadow utilities#38816julien-deramond merged 2 commits intotwbs:mainfrom craigiswayne:feature/box-shadow-css-variables
box-shadow CSS variables shadow utilities#38816julien-deramond merged 2 commits intotwbs:mainfrom
craigiswayne:feature/box-shadow-css-variables
Conversation
louismaximepiton
approved these changes
Jun 27, 2023
Member
louismaximepiton
left a comment
There was a problem hiding this comment.
LGTM, Thanks for the contribution!
I wonder if we should change all the occurences of $box-shadow* in our Scss. It can maybe be done afterwards (_variables.scss, _navbar.scss, sidebar.scss).
box-shadow CSS variables shadow utilities
mdo
approved these changes
Jul 6, 2023
Member
|
@julien-deramond @louismaximepiton Thoughts on making this stuff part of a v5.3.1 or v5.3.2? Wondering if this counts as anything more meaningful than just a general quality of life improvement and consistency change. |
Member
|
I think you're right it's only general improvement for quality of life. I guess that it could be merged whenever but I think the sooner the better. However, I don't have a strong opinion whether it should be in v5.3.1 or v5.3.2. |
4 tasks
romankupchak93
pushed a commit
to romankupchak93/bootstrap
that referenced
this pull request
Jan 5, 2024
This was referenced May 19, 2024
This was referenced May 24, 2024
This was referenced Oct 2, 2024
This was referenced Oct 5, 2024
This was referenced Oct 12, 2024
This was referenced Oct 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently the shadow utility css classes have the following code:
This PR would result in the following change:
Making use of css box-shadow variables in the shadow utility classes
The values of these css variables are unchanged and are as follows
As you can see they are the same value as the sass variables
these box-shadow css variables only seemed to be currently in use by the following:
The resulting values of these box shadow's don't change
Motivation & Context
To allow overriding the shadow utility classes without the use of
!importantor sass variablesType of changes
Checklist
npm run lint)Live previews
Not sure if i need to do this
Related issues
None. There are a few issues related to shadows, but none specifically asking for css variables in the current shadow utility classes