Remove duplicate $alert-*-scale Sass vars#38674
Conversation
|
Is it possible these variables already stopped working in Bootstrap 5.3.0? Is there a recommended alternative for this? |
|
Hi @kreintjes Please note for your next questions that the GitHub Discussions > Q&A is more appropriate. Having questions in already merged PRs or closed issues is difficult to track for us :) Back to your question, Before we did the following: @each $state, $value in $theme-colors {
$alert-background: shift-color($value, $alert-bg-scale);
$alert-border: shift-color($value, $alert-border-scale);
$alert-color: shift-color($value, $alert-color-scale);
/* etc. */
}The dark mode doesn't permit keeping this solution so it's now defined as Lines 60 to 67 in 60098ac If you'd like to keep the previous system, you'll need to override the rules in your project. |
Description
This PR removes duplicate
$alert-bg-scale,$alert-border-scaleand$alert-color-scaledefinitions in_variables.scss.Motivation & Context
Even if it will be removed in v6, let's avoid duplication right now.
Type of changes
Checklist
npm run lint)Live previews
Related issues
Closes #38672