Fix StackBlitz examples needing docs CSS#36637
Merged
julien-deramond merged 1 commit intomainfrom Jun 28, 2022
Merged
Conversation
93 tasks
julien-deramond
force-pushed
the
main-jd-fix-stackblitz-examples-by-adding-docs-css
branch
from
3c3803b to
35753db
Compare
Member
|
Loading the docs makes sense to me since that's what we build and publish. Adding a separate stylesheet would be an extra HTTP request. Alternatively we can try to build everything for the snippets with local Just gives extra motivation to reduce the docs/examples CSS as much as possible. |
mdo
approved these changes
Jun 28, 2022
julien-deramond
deleted the
main-jd-fix-stackblitz-examples-by-adding-docs-css
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference #36391
Originally I wanted to be able to load only _component-examples.scss and only when needed. The main issue is that it contains Sass variables defined in other Sass files; including files in the framework.
It will be less obvious for the users but the only other way I found so far is to load directly in the
index.htmlourdocs.css...Any other ideas?
Fixed use cases
.bd-examplein order to add margin tops between form controls.