Skip to content

Fix StackBlitz Popovers and Tooltips examples#36449

Merged
mdo merged 5 commits intomainfrom
main-jd-refine-popovers-and-tooltips-examples-for-stackblitz
Jun 20, 2022
Merged

Fix StackBlitz Popovers and Tooltips examples#36449
mdo merged 5 commits intomainfrom
main-jd-refine-popovers-and-tooltips-examples-for-stackblitz

Conversation

@julien-deramond
Copy link
Copy Markdown
Member

@julien-deramond julien-deramond commented May 27, 2022 •
edited
Loading

Step 2 of #36391

This PR contains

  • New stackblitz option for the example shortcode
  • Rename js_snippet to stackblitz_add_js option for the example shortcode in order to identify easily what's related to StackBlitz
  • Rewrite the example shortcode's documentation and reorder the options
  • Hide the StackBlitz edit button of the first Popover example and use data-bs-title instead of title for the other Popover examples as discussed in Allow popovers examples to be tried on StackBlitz #36127 (comment)
  • ⚠️ Use data-bs-title instead of title for the Tooltip and Popover examples

Live previews

Popovers

Tooltips

@julien-deramond julien-deramond marked this pull request as ready for review May 27, 2022 14:57
@julien-deramond julien-deramond requested a review from a team May 27, 2022 14:58
@GeoSot GeoSot force-pushed the main-jd-refine-popovers-and-tooltips-examples-for-stackblitz branch from c25eb38 to 5ac36b6 Compare May 31, 2022 10:39
mdo
mdo reviewed Jun 1, 2022
View reviewed changes
@julien-deramond julien-deramond mentioned this pull request Jun 5, 2022
Open
93 tasks
@julien-deramond
Copy link
Copy Markdown
Member Author

julien-deramond commented Jun 8, 2022

Following a discussion with @GeoSot a4153f4 contains the following modifications:

  • Removing of stackblitz param for the example shortcode only used in one example to simplify the use of this shortcode
  • It implies that all popovers and tooltips examples in the doc use data-bs-title instead of title
  • A reusable warning callout is in place (wording should be improved; if you have a better way to explain it don't hesitate :) )

@julien-deramond julien-deramond requested a review from GeoSot June 8, 2022 20:51
mdo
mdo reviewed Jun 8, 2022
View reviewed changes
@GeoSot GeoSot force-pushed the main-jd-refine-popovers-and-tooltips-examples-for-stackblitz branch from e40ed53 to 31ac201 Compare June 9, 2022 17:59
@GeoSot
Copy link
Copy Markdown
Member

GeoSot commented Jun 9, 2022 •
edited
Loading

I think is fine now. Thanks a lot @julien-deramond 😄
@mdo if you are ok with it, lets merge it

@GeoSot GeoSot force-pushed the main-jd-refine-popovers-and-tooltips-examples-for-stackblitz branch from 31ac201 to 48a081f Compare June 20, 2022 12:12
@mdo mdo merged commit cfabeb7 into main Jun 20, 2022
@mdo mdo deleted the main-jd-refine-popovers-and-tooltips-examples-for-stackblitz branch June 20, 2022 14:19
@julien-deramond julien-deramond mentioned this pull request Jun 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mdo mdo mdo approved these changes

@GeoSot GeoSot GeoSot approved these changes

Assignees

No one assigned

Labels

docs js v5

Projects

No open projects
v5.2.0-stable
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@julien-deramond @GeoSot @mdo