Fix StackBlitz edit feature by selecting the closest example#36088
Merged
Fix StackBlitz edit feature by selecting the closest example#36088
Conversation
Member
Author
|
Before going further here I'd like a first feedback on this PR :) I propose to tackle this topic with multiple steps:
What do you think? |
48 tasks
Member
|
Nice catch @julien-deramond . I would prefer the multiple steps approach. It is better to fix to issue first, and in another step to check which examples need to be 'fixed' or with hidden edti-btn |
95 tasks
julien-deramond
force-pushed
the
main-jd-fix-stackblitz-examples
branch
from
113a173 to
b030ef5
Compare
Member
Author
Member
|
Thank you to @julien-deramond . As always, fast and effective |
GeoSot
approved these changes
Mar 31, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is a proposal to fix the fact that the StackBlitz edit button creates a StackBlitz env only with the first example of the page due to
event.target.closest('.bd-content')and that pages only have one.bd-content.For example https://twbs-bootstrap.netlify.app/docs/5.1/components/accordion/#flush will create a StackBlitz env with the content of https://twbs-bootstrap.netlify.app/docs/5.1/components/accordion/#example.
I've changed the selector in order to have the closest example of the edit button (the sibling example).
Types of changes
Checklist
npm run lint)Related issues
N/A
Live previews