Skip to content

Popover/Tooltip: Fix vertical alignment on arrow of tip elements#35527

Merged
XhmikosR merged 3 commits intomainfrom
gs/achieve-vertical-alignment-on-popovers
Dec 21, 2021
Merged

Popover/Tooltip: Fix vertical alignment on arrow of tip elements#35527
XhmikosR merged 3 commits intomainfrom
gs/achieve-vertical-alignment-on-popovers

Conversation

@GeoSot
Copy link
Copy Markdown
Member

@GeoSot GeoSot commented Dec 10, 2021

Regression of #32692

Fixes #35453

@GeoSot
Copy link
Copy Markdown
Member Author

GeoSot commented Dec 10, 2021

@julien-deramond you may check the 'fix' here. If you have any other more valid suggestion, I would like to hear it 😃

@julien-deramond
Copy link
Copy Markdown
Member

@julien-deramond you may check the 'fix' here. If you have any other more valid suggestion, I would like to hear it smiley

I tried other approaches the other day without succeeding. IMO it only happens at the "init" phase. Your fix corresponds to that so I haven't any other more valid suggestion 😃 Thanks for the fix @GeoSot!

@XhmikosR XhmikosR changed the title Popover/Tooltip.js: Achieve vertical alignment on arrow, of tip elements Popover/Tooltip: Achieve vertical alignment on arrow of tip elements Dec 16, 2021
@XhmikosR XhmikosR changed the title Popover/Tooltip: Achieve vertical alignment on arrow of tip elements Popover/Tooltip: Fix vertical alignment on arrow of tip elements Dec 16, 2021
@XhmikosR XhmikosR force-pushed the gs/achieve-vertical-alignment-on-popovers branch from bf776c7 to 32d6615 Compare December 16, 2021 08:08
@XhmikosR XhmikosR marked this pull request as ready for review December 21, 2021 14:44
@XhmikosR XhmikosR requested a review from a team as a code owner December 21, 2021 14:44
@XhmikosR XhmikosR merged commit 65cf77a into main Dec 21, 2021
@XhmikosR XhmikosR deleted the gs/achieve-vertical-alignment-on-popovers branch December 21, 2021 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Vertical alignment of popovers

3 participants