Clean tooltip component unneeded functionality #32692
Conversation
|
So, basically this removes the ability to use the CSS classes for positioning the tooltips? Not sure I follow all the changes. @MartijnCuppens you recently had a look at popper too. |
This is the half truth ;) it still uses this: .bs-tooltip-auto {
&[data-popper-placement^="top"] {
@extend .bs-tooltip-top;
}
&[data-popper-placement^="right"] {
@extend .bs-tooltip-end;
}
&[data-popper-placement^="bottom"] {
@extend .bs-tooltip-bottom;
}
&[data-popper-placement^="left"] {
@extend .bs-tooltip-start;
}
}and as important on my opinion, it removes many of js, to be easier for future maintenance. This can do the difference too I only chose this solution as it pulls out some extra stuff |
0f2d321 to
1cbddbf
Compare
|
So, this patch still has the issue with tooltip randomly showing up in the wrong position when hovering fast, multiple times. But at least, it does show. |
If we remove the Also popper overrides the css properties |
|
@GeoSot @rohit2sharma95 What work remains here? I see tests are failing and we might still have the same issue with the fast hovering bug. Do we need to do something similar as #32843? Something else? |
I'm down to try anything at this point :). @rohit2sharma95 and @XhmikosR would know better what the implications of that might be though. |
|
I'm still seeing the issue with tooltip showing to the wrong position when hovering too fast. :/ |
|
@XhmikosR |
|
Confirmed, now it works! @rohit2sharma95 please review this, I added it in beta2 :) |
|
@GeoSot do the current tests in this branch catch this issue? We should make sure this doesn't happen again :) |
|
if you have any idea, how to do these tests, I would appreciate, any help or opinion |
|
Unfortunately, I don't know how either. Maybe @rohit2sharma95 can help us here? |
|
Removing the default value for |
|
We definitely need tests for this... Tomorrow we'll release beta2, so if this isn't ready we'll move it beta3 to that there's no time pressure. |
50b1ee0 to
58bab0d
Compare
58e9a4c to
dde15ec
Compare
120590e to
a80005c
Compare
Remove a leftover after #32692 Co-authored-by: XhmikosR <[email protected]>
) Regression of #32692 Co-authored-by: XhmikosR <[email protected]>
Preview: https://deploy-preview-32692--twbs-bootstrap.netlify.app/docs/5.1/components/tooltips/