Skip to content

Add IndentSelection#148

Merged
tvrzna merged 18 commits intotvrzna:masterfrom
oSoWoSo:master
Nov 25, 2025
Merged

Add IndentSelection#148
tvrzna merged 18 commits intotvrzna:masterfrom
oSoWoSo:master

Conversation

@zen0bit
Copy link
Copy Markdown
Contributor

@zen0bit zen0bit commented Nov 6, 2025

Closes #147

Not (yet) sure where I can find Select [6]: to also move it...

@zen0bit zen0bit marked this pull request as draft November 6, 2025 12:23
@zen0bit
Copy link
Copy Markdown
Contributor Author

zen0bit commented Nov 6, 2025

extraIndent
emptty2

@zen0bit
Copy link
Copy Markdown
Contributor Author

zen0bit commented Nov 6, 2025 •
edited
Loading

Logo I can move easily with custom MOTD
But still don't know where to find Select [number]: to also move it

Also how to create test for [10] Plasma (Wayland)

@tvrzna
Copy link
Copy Markdown
Owner

tvrzna commented Nov 6, 2025

The Select prompt is in desktop.go.

How do you mean create a test? To print more than 9 DE/WMs? If so, then you can mock in as it is in desktop_test.go:TestPrintDesktops.

@zen0bit
Copy link
Copy Markdown
Contributor Author

zen0bit commented Nov 6, 2025

emptty3

@zen0bit zen0bit marked this pull request as ready for review November 6, 2025 21:24
@zen0bit zen0bit changed the title WIP: Add IndentSelection Add IndentSelection Nov 6, 2025
@tvrzna tvrzna self-requested a review November 10, 2025 06:02
@tvrzna tvrzna added the enhancement New feature or request label Nov 10, 2025
@tvrzna
Copy link
Copy Markdown
Owner

tvrzna commented Nov 10, 2025

Added some review, I like your elegant and simple solution. Good job!

@zen0bit
Copy link
Copy Markdown
Contributor Author

zen0bit commented Nov 21, 2025

Added some review, I like your elegant and simple solution. Good job!

Don't see any review
Anything I have to change to get this PR merged?

tvrzna
tvrzna reviewed Nov 21, 2025
View reviewed changes
@tvrzna
Copy link
Copy Markdown
Owner

tvrzna commented Nov 21, 2025

Added some review, I like your elegant and simple solution. Good job!

Don't see any review Anything I have to change to get this PR merged?

I don't know what say. I'm really sorry, I haven't submitted the reviewed comments and I hadn't noticed that.
Please accept my apology for this dumb delay.

@zen0bit
Copy link
Copy Markdown
Contributor Author

zen0bit commented Nov 21, 2025 •
edited
Loading

I don't know what say. I'm really sorry, I haven't submitted the reviewed comments and I hadn't noticed that. Please accept my apology for this dumb delay.

No problem

Everything should be sorted out

Please check it

PS: Maybe also move Login and Password prompt?
🤔

@zen0bit zen0bit requested a review from tvrzna November 21, 2025 20:47
tvrzna
tvrzna reviewed Nov 24, 2025
View reviewed changes
tvrzna
tvrzna reviewed Nov 24, 2025
View reviewed changes
tvrzna
tvrzna reviewed Nov 24, 2025
View reviewed changes
Copy link
Copy Markdown
Owner

@tvrzna tvrzna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another little review. It looks like it is really close to the merge, nice work!

@zen0bit zen0bit requested a review from tvrzna November 24, 2025 14:56
@tvrzna
Copy link
Copy Markdown
Owner

tvrzna commented Nov 25, 2025

Looks good to me!
Thank you for the PR and the patience with me.

@tvrzna tvrzna merged commit 852a0e1 into tvrzna:master Nov 25, 2025
7 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tvrzna tvrzna Awaiting requested review from tvrzna

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Show emptty in middle of screen

2 participants

@zen0bit @tvrzna