Draft
Conversation
This reverts commit 21c1e1c.
When a check_fn is specified in a S3KeySensor, the S3 key itself should be available in each element of the `files` list to better associate given metadata with the key. This adds a key `"Key": str` to the metadata dictionary for each S3 key.
The `metadata_keys` list had `["Size", "Key"]` as a default value to mirror the default from S3KeySensor, but was unnecessary since it got overwritten with the S3 key.
tuzonghua
force-pushed
the
amazon/fix-s3keysensor-metadata-dict
branch
from
7a87351 to
0f35873
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes apache#44896. Prior work had added
"Key"to the S3KeySensormetadata_keysdefault value but didn't correctly set the value in thefileslist provided tocheck_fn. This sets the value correctly as well as updates outdated documentation to reflect the change.Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.