Add initial test#60
Conversation
f23d090 to
5289e3f
Compare
|
Looks like the build hangs on AppVeyor. Wonder what the difference is between that environment and my machine. |
|
@jnm2 I'm going to push to this branch with some updates 👍 |
|
Dotnet msbuild is not going to work unless you add the new netfx reference assembly NuGet package reference. |
30c285f to
cdc1dff
Compare
eed2eb4 to
dca0885
Compare
a9dc875 to
405e1ce
Compare
|
@jnm2 I'll finish this in the morning and merge it. 😀 |
405e1ce to
697bb09
Compare
|
|
||
| <ItemGroup> | ||
| <!-- https://github.com/dotnet/core-sdk/issues/2022 --> | ||
| <PackageReference Condition="'$(TargetFramework)' == 'net35'" Include="jnm2.ReferenceAssemblies.net35" Version="1.0.0" PrivateAssets="all" /> |
| test_script: | ||
| - git clean -dxf tests | ||
| - msbuild /restore tests/MultiTFM /warnaserror /v:m | ||
| - git clean -dxf tests | ||
| - msbuild /restore tests/SingleTFM /p:TestFramework=net35 /warnaserror /v:m | ||
| - git clean -dxf tests | ||
| - msbuild /restore tests/SingleTFM /p:TestFramework=net48 /warnaserror /v:m | ||
| - git clean -dxf tests | ||
| - msbuild /restore tests/SingleTFM /p:TestFramework=netstandard1.6 /warnaserror /v:m | ||
| - git clean -dxf tests | ||
| - msbuild /restore tests/SingleTFM /p:TestFramework=netstandard2.0 /warnaserror /v:m | ||
| - git clean -dxf tests | ||
| - msbuild /restore tests/SingleTFM /p:TestFramework=netcoreapp1.0 /p:DisableImplicitNuGetFallbackFolder=true /warnaserror /v:m | ||
| - git clean -dxf tests | ||
| - msbuild /restore tests/SingleTFM /p:TestFramework=netcoreapp1.1 /p:DisableImplicitNuGetFallbackFolder=true /warnaserror /v:m | ||
|
|
||
| - git clean -dxf tests | ||
| - dotnet msbuild -restore tests/MultiTFM -warnaserror -v:m | ||
| - taskkill /im dotnet.exe /f | ||
| - git clean -dxf tests | ||
| - dotnet msbuild -restore tests/SingleTFM -p:TestFramework=net35 -warnaserror -v:m | ||
| - taskkill /im dotnet.exe /f | ||
| - git clean -dxf tests | ||
| - dotnet msbuild -restore tests/SingleTFM -p:TestFramework=net48 -warnaserror -v:m | ||
| - taskkill /im dotnet.exe /f | ||
| - git clean -dxf tests | ||
| - dotnet msbuild -restore tests/SingleTFM -p:TestFramework=netstandard1.6 -warnaserror -v:m | ||
| - taskkill /im dotnet.exe /f | ||
| - git clean -dxf tests | ||
| - dotnet msbuild -restore tests/SingleTFM -p:TestFramework=netstandard2.0 -warnaserror -v:m | ||
| - taskkill /im dotnet.exe /f | ||
| - git clean -dxf tests | ||
| - dotnet msbuild -restore tests/SingleTFM -p:TestFramework=netcoreapp1.0 -p:DisableImplicitNuGetFallbackFolder=true -warnaserror -v:m | ||
| - taskkill /im dotnet.exe /f | ||
| - git clean -dxf tests | ||
| - dotnet msbuild -restore tests/SingleTFM -p:TestFramework=netcoreapp1.1 -p:DisableImplicitNuGetFallbackFolder=true -warnaserror -v:m |
There was a problem hiding this comment.
I was looking for something I could queue up from the command line. Do you mind if I add back a .ps1 or .cmd? git clean -fxd test was something I was thinking about.
/nodeReuse:false or env MSBUILDDISABLENODEREUSE=1 can be used rather than taskkill IIRC.
There was a problem hiding this comment.
They are also recommended for CI:
But since it's important to tell people with CI servers and so on to disable node reuse, we should have clear documentation in the usual place.
There was a problem hiding this comment.
But since it's important to tell people with CI servers and so on to disable node reuse, we should have clear documentation in the usual place.
This only applies to build servers that share state across builds. No CI server should ever be doing this (and neither AppVeyor nor Travis have this problem).
| - git clean -dxf tests | ||
| - msbuild /restore tests/MultiTFM /warnaserror /v:m | ||
| - git clean -dxf tests | ||
| - msbuild /restore tests/SingleTFM /p:TestFramework=net35 /warnaserror /v:m |
There was a problem hiding this comment.
@sharwell What would happen if this was /p:TargetFramework=net35 and <TargetFramework>$(TestFramework)</TargetFramework> was removed from the csproj?
2 participants
Fixes #51
I did this really fast. Feel free to modify or replace.