Fix assembly resolution for more target frameworks#59
Merged
sharwell merged 13 commits intoDec 31, 2019
Merged
Conversation
This was referenced Dec 29, 2019
sharwell
reviewed
Dec 29, 2019
jnm2
force-pushed
the
fix_assembly_resolution_for_more_target_frameworks
branch
2 times, most recently
from
December 29, 2019 20:20
01fa3ce to
d99c2f4
Compare
Member
sharwell
reviewed
Dec 30, 2019
…ing as .NET Standard 1.x
…ing as .NET Standard 1.x
…reating as .NET Standard 1.x
jnm2
force-pushed
the
fix_assembly_resolution_for_more_target_frameworks
branch
from
December 31, 2019 02:26
d99c2f4 to
09e1988
Compare
….0+ and netstandard2.1+
…otated assemblies to use a different version of the annotations
jnm2
force-pushed
the
fix_assembly_resolution_for_more_target_frameworks
branch
from
December 31, 2019 02:30
09e1988 to
af64004
Compare
Contributor
Author
|
@sharwell Tests pass, ready for review! I didn't put any effort into making things pretty (out of time). Maybe the netstandard1.6 sections could be unified with the netcoreapp1.x sections. |
sharwell
reviewed
Dec 31, 2019
Co-Authored-By: Sam Harwell <[email protected]>
…se and not set up on the build server) This reverts commit f42af4e.
sharwell
approved these changes
Dec 31, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #38
Fixes #50
Supersedes #49
I verified that source attributes are added by default when appropriate and rewritten assemblies are being used by CscTask for
<TargetFrameworks>net35;net48;netstandard1.6;netstandard2.0;netstandard2.1;netcoreapp2.1;netcoreapp3.0;netcoreapp3.1</TargetFrameworks>.