Use deferred reading mode so that AssemblyResolutionException is handled per type#39
Merged
Merged
Conversation
…n if part of it can't
jnm2
changed the title
jnm2
marked this pull request as ready for review
October 16, 2019 22:16
sharwell
approved these changes
Oct 17, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #37. I'm not sure if there's another place we should be catching
AssemblyResolutionException, but if so, Shouldly's CI avoided it and built successfully.Before: https://ci.appveyor.com/project/shouldly/shouldly/builds/28135259/job/cjgxr82wq8ohegu2#L767
After (using
[1.0.0-alpha.80.g0c15c15c1b]from the AppVeyor feed): https://ci.appveyor.com/project/shouldly/shouldly/builds/28163994/job/mw9jc5olkhocfk25