Skip to content

Respect NoWarn in project#34

Merged
sharwell merged 7 commits into
tunnelvisionlabs:masterfrom
jnm2:nowarn
Oct 3, 2019
Merged

Respect NoWarn in project#34
sharwell merged 7 commits into
tunnelvisionlabs:masterfrom
jnm2:nowarn

Conversation

@jnm2

@jnm2 jnm2 commented Sep 30, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

Closes #31. Confirmed that the warning disappeared after updating to the locally build package using a net35 project with the System.Data warning.

I tested against this weird NoWarn property to verify that I had declared the task property in a valid way. string[] appears to trigger automatic splitting and trimming.

<Project Sdk="Microsoft.NET.Sdk">

  <PropertyGroup>
    <TargetFramework>net35</TargetFramework>
    <LangVersion>latest</LangVersion>
    <Nullable>enable</Nullable>
    <AnnotatedReferenceAssemblyVersion>3.0.0</AnnotatedReferenceAssemblyVersion>
    <NoWarn>; ; RA1000 ;; </NoWarn>
  </PropertyGroup>

  <ItemGroup>
    <PackageReference Include="TunnelVisionLabs.ReferenceAssemblyAnnotator" Version="1.0.0-alpha.*" PrivateAssets="all" />
    <PackageDownload Include="Microsoft.NETCore.App.Ref" Version="[$(AnnotatedReferenceAssemblyVersion)]" />
  </ItemGroup>

</Project>

jnm2
jnm2 commented Oct 1, 2019
View reviewed changes
Comment thread TunnelVisionLabs.ReferenceAssemblyAnnotator/SuppressibleLoggingHelper.cs
sharwell
sharwell requested changes Oct 1, 2019
View reviewed changes
Comment thread TunnelVisionLabs.ReferenceAssemblyAnnotator/AnnotatorBuildTask.cs Outdated
jnm2
jnm2 commented Oct 1, 2019
View reviewed changes
Comment thread TunnelVisionLabs.ReferenceAssemblyAnnotator/SuppressibleLoggingHelper.cs Outdated
@jnm2
jnm2 requested a review from sharwell October 1, 2019 13:33
sharwell
sharwell reviewed Oct 2, 2019
View reviewed changes
Comment thread TunnelVisionLabs.ReferenceAssemblyAnnotator/AnnotatorBuildTask.cs Outdated
Comment thread TunnelVisionLabs.ReferenceAssemblyAnnotator/SuppressibleLoggingHelper.cs Outdated
Comment thread TunnelVisionLabs.ReferenceAssemblyAnnotator/SuppressibleLoggingHelper.cs Outdated
Comment thread TunnelVisionLabs.ReferenceAssemblyAnnotator/SuppressibleLoggingHelper.cs Outdated
Comment thread TunnelVisionLabs.ReferenceAssemblyAnnotator/Program.cs Outdated
@jnm2
jnm2 requested a review from sharwell October 2, 2019 20:05
@sharwell
sharwell merged commit c25b73d into tunnelvisionlabs:master Oct 3, 2019
@jnm2
jnm2 deleted the nowarn branch October 3, 2019 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sharwell sharwell sharwell approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

NoWarn doesn't suppress RA1000

2 participants

@jnm2 @sharwell