Merged
Conversation
Hi Tung, does this answer the ticket? Add the sample code from samples/run_sample.sh to samples/README.md tungbq#96 Also, should I add the installation to the script? (from https://charts.bitnami.com/) I guess something like: helm install sample-release bitnami/| grep jenkins
tungbq
reviewed
Mar 18, 2024
tungbq
reviewed
Mar 18, 2024
Owner
|
Thanks for the first PR in this repository @Chrisgr1. Appreciated, just minor comment about the heading format, could you please check and fix it? |
corrected formatting of kubectl Co-authored-by: Tung Leo <[email protected]>
Correct formatting on Helm section Co-authored-by: Tung Leo <[email protected]>
This was referenced Mar 18, 2024
Chrisgr1
commented
Mar 18, 2024
Contributor
Author
Chrisgr1
left a comment
Chrisgr1
left a comment
There was a problem hiding this comment.
Updated to correct format
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Tung, does this answer the ticket?
Add the sample code from samples/run_sample.sh to samples/README.md #96
Also, should I add the installation to the script? (from https://charts.bitnami.com/) I guess something like:
helm install sample-release bitnami/| grep jenkins
Closes: #96
Changes