Skip to content

Comments

revert(cli): revert static framework resource embedding#9446

Merged
pepicrft merged 2 commits intomainfrom
revert/static-framework-resource-embedding
Feb 13, 2026
Merged

revert(cli): revert static framework resource embedding#9446
pepicrft merged 2 commits intomainfrom
revert/static-framework-resource-embedding

Conversation

@pepicrft
Copy link
Contributor

Summary

This reverts the static framework resource embedding feature introduced across PRs #9081, #9141, #9210, #9240, #9317, #9382, #9419, and their related fixes. Static framework resources go back to being placed in separate .bundle targets rather than being embedded directly inside the framework.

The approach of embedding resources inside static frameworks caused enough edge cases and regressions that we're reverting to the previous well-tested behavior while we rethink the approach. The cache version has been bumped to invalidate artifacts built with the embedding approach.

Test plan

  • Existing unit and acceptance tests have been updated to match the reverted behavior
  • Example fixtures specific to the embedding approach have been removed
  • Cache version bumped to force rebuild of cached artifacts

This reverts the static framework resource embedding feature that was
introduced across multiple PRs (#9081, #9141, #9210, #9240, #9317,
#9382, #9419 and related fixes). Resources for static frameworks go
back to being placed in separate .bundle targets instead of being
embedded inside the framework itself.

The cache version is bumped to invalidate artifacts built with the
old embedding approach.
@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Feb 13, 2026
@dosubot
Copy link

dosubot bot commented Feb 13, 2026

Related Documentation

Checked 1 published document(s) in 1 knowledge base(s). No updates required.

How did I do? Any feedback?  Join Discord

@tuist
Copy link

tuist bot commented Feb 13, 2026

🛠️ Tuist Run Report 🛠️

Previews 📦

App Commit Open on device
Tuist 938b53d80

Tests 🧪

Scheme Status Cache hit rate Tests Skipped Ran Commit
TuistApp 0 % 21 0 21 938b53d80
TuistAutomationAcceptanceTests 67 % 33 0 33 0047af4a8
TuistCacheEEAcceptanceTests 65 % 14 0 14 938b53d80
TuistCacheEEUnitTests 65 % 119 0 119 938b53d80
TuistDependenciesAcceptanceTests 67 % 16 0 16 0047af4a8
TuistGeneratorAcceptanceTests 67 % 71 0 71 0047af4a8
TuistKitAcceptanceTests 67 % 43 0 43 938b53d80

Builds 🔨

Scheme Status Duration Commit
TuistApp 2m 26s 938b53d80
TuistAutomationAcceptanceTests 4m 11s 938b53d80
TuistCacheEEAcceptanceTests 1m 10s 938b53d80
TuistCacheEEUnitTests 43.1s 938b53d80
TuistDependenciesAcceptanceTests 3m 18s 938b53d80
TuistGeneratorAcceptanceTests 3m 46s 938b53d80
TuistKitAcceptanceTests 3m 12s 938b53d80
TuistUnitTests 1m 20s 938b53d80

Bundles 🧰

Bundle Commit Install size Download size
Tuist 938b53d80
30.3 MB
Δ +2.7 MB (+9.80%)
15.3 MB
Δ +450.8 KB (+3.04%)

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 13, 2026
XcodeGraph 1.31.0 changed staticFramework to return supportsResources=true.
The ResourcesProjectMapper needs to create separate resource bundles for
static frameworks regardless, so add explicit staticFramework checks.
Also update hash expectations and fix lint issues.
@pepicrft pepicrft merged commit fbeb6ce into main Feb 13, 2026
21 of 25 checks passed
@pepicrft pepicrft deleted the revert/static-framework-resource-embedding branch February 13, 2026 14:30
fortmarek added a commit that referenced this pull request Feb 19, 2026
PR #9446 (revert static framework resource embedding) accidentally
removed the resolvingSrcRootPaths logic from PR #9203 that corrects
$(SRCROOT)-relative paths when propagating settings from cached targets
at different project paths.

Without this fix, FRAMEWORK_SEARCH_PATHS and HEADER_SEARCH_PATHS
for external static xcframeworks are computed relative to the cached
target's location (.cache/tuist/Binaries/HASH/) instead of the
consuming app's project directory, producing broken paths.

Co-Authored-By: Claude Opus 4.6 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:XXL This PR changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants