Skip to content

Comments

fix(cli): embed static frameworks with buildable-folder resources#9317

Merged
pepicrft merged 3 commits intomainfrom
fix/static-framework-buildable-folder-resources
Feb 3, 2026
Merged

fix(cli): embed static frameworks with buildable-folder resources#9317
pepicrft merged 3 commits intomainfrom
fix/static-framework-buildable-folder-resources

Conversation

@pepicrft
Copy link
Contributor

@pepicrft pepicrft commented Feb 2, 2026

Summary

  • Treat buildable-folder resources as target resources for embeddable checks
  • Embed static frameworks that only have buildable-folder resources
  • Add GraphTraverser test coverage

Context

Testing

  • Not run (not requested)

@dosubot dosubot bot added the size:M For issues that take a handful of hours to implement label Feb 2, 2026
@pepicrft pepicrft self-assigned this Feb 2, 2026
@pepicrft pepicrft requested review from a team, cschmatzler and fortmarek and removed request for a team February 2, 2026 18:25
@dosubot dosubot bot added domain:cli Issues related to the CLI that don't fall into a particular feature category. type:bug Something isn't working labels Feb 2, 2026
@tuist
Copy link

tuist bot commented Feb 2, 2026

🛠️ Tuist Run Report 🛠️

Tests 🧪

Scheme Status Cache hit rate Tests Skipped Ran Commit
TuistCacheEEAcceptanceTests 0 % 14 0 14 54bb3b301
TuistDependenciesAcceptanceTests 87 % 18 0 18 54bb3b301
TuistGeneratorAcceptanceTests 0 % 72 0 72 54bb3b301
TuistUnitTests 0 % 2252 0 2252 54bb3b301

Builds 🔨

Scheme Status Duration Commit
TuistAutomationAcceptanceTests 3m 3s 54bb3b301
TuistCacheEEAcceptanceTests 1m 15s 54bb3b301
TuistDependenciesAcceptanceTests 1m 49s 54bb3b301
TuistGeneratorAcceptanceTests 5m 44s 54bb3b301
TuistKitAcceptanceTests 1m 15s 54bb3b301
TuistUnitTests 1m 40s 54bb3b301

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 3, 2026
@pepicrft pepicrft merged commit 228b59b into main Feb 3, 2026
18 of 19 checks passed
@pepicrft pepicrft deleted the fix/static-framework-buildable-folder-resources branch February 3, 2026 09:11
pepicrft added a commit that referenced this pull request Feb 13, 2026
This reverts the static framework resource embedding feature that was
introduced across multiple PRs (#9081, #9141, #9210, #9240, #9317,
#9382, #9419 and related fixes). Resources for static frameworks go
back to being placed in separate .bundle targets instead of being
embedded inside the framework itself.

The cache version is bumped to invalidate artifacts built with the
old embedding approach.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

domain:cli Issues related to the CLI that don't fall into a particular feature category. lgtm This PR has been approved by a maintainer size:M For issues that take a handful of hours to implement type:bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Static frameworks with buildable folders with resources don't copy into applicaton bundle

2 participants