fix(cli): restore static framework resources without regressions#9081
fix(cli): restore static framework resources without regressions#9081
Conversation
cli/Sources/TuistGenerator/Mappers/ResourcesProjectMapper.swift
Outdated
Show resolved
Hide resolved
fortmarek
left a comment
There was a problem hiding this comment.
Manually tested this with the generated_ios_app_with_static_frameworks_with_resources and generated_local_spm_dependency_with_assets examples and, including caching, everything looked good.
I think this one is worth writing a short community post for and post it in #general, as the change is significant enough that we want folks to be aware of it.
cli/Sources/TuistGenerator/Mappers/ResourcesProjectMapper.swift
Outdated
Show resolved
Hide resolved
cli/Tests/TuistGeneratorAcceptanceTests/GenerateAcceptanceTests.swift
Outdated
Show resolved
Hide resolved
|
I've been looking at Tuist for our very large brownfield project. We use local swift packages as the vehicle for modularity, and also happen to use generated accessors across many different modules. This will do so much towards allowing us to evaluate Tuist without bloodshed. Thank you. |
1d97088 to
81a997b
Compare
@nicorichard I'll have this one merged today ;) |
|
Just reporting back to say that I pulled the new release (CLI 4.122.2) and my codebase just ran its first successful build using a Tuist generated project 🎉 |
|
@pepicrft @fortmarek Thank you for doing this! I've been waiting for this for a long time. After testing this change I spotted a couple of issues I think you might want to take a look at though. One thing is I think there's an issue with the generated Another issue seems to be with Metal files in a static framework. A framework with Metal files will also contain a |
|
Thanks @adarhef. I'm taking a look at it. |
|
Hello. Would some of you help me with a link to documentation about how to set the resources synthesiser? This is my configuration:
If someone could hint me with ideas that would be great. |
This reverts the static framework resource embedding feature that was introduced across multiple PRs (#9081, #9141, #9210, #9240, #9317, #9382, #9419 and related fixes). Resources for static frameworks go back to being placed in separate .bundle targets instead of being embedded inside the framework itself. The cache version is bumped to invalidate artifacts built with the old embedding approach.

Summary
Testing
mise x -- tuist test TuistGeneratorAcceptanceTests(completed; test action reported no tests to run in this scheme)Related