Fix unstable hash when a dependency is resolved both via registry and scm#7518
Merged
Fix unstable hash when a dependency is resolved both via registry and scm#7518
Conversation
pepicrft
approved these changes
Apr 22, 2025
cschmatzler
approved these changes
Apr 22, 2025
🛠️ Tuist Run Report 🛠️Tuist Tests 🧪
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #7515
Short description 📝
When a transitive dependency is referenced with the registry identifier in the
Package.swiftwithout the--replace-scm-with-registryflag being used, SwiftPM ends up resolving both the scm and registry variant of the dependency. Tuist then ends up "randomly" using one or the other.This PR fixes the issue by preferring a registry dependency if available. However, we recommend using
--replace-scm-with-registryas a dependency resolved twice with possibly different versions is rarely what you want.How to test the changes locally 🧐
Contributor checklist ✅
mise run lint-fixReviewer checklist ✅
changelog:added,changelog:fixed, orchangelog:changed, and the title is usable as a changelog entry